Skip to content

feat(asset): add importMode: "newURL" #11725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat(asset): add importMode: "newURL" #11725

wants to merge 3 commits into from

Conversation

SoonIter
Copy link
Member

@SoonIter SoonIter commented Sep 21, 2025 •
edited
Loading

Summary

feat(asset): add importMode: "newURL"

input

// foo.png

import foo from './foo.png'
console.log(foo)

importMode: 'newUrl' output

const foo = /*#__PURE__*/  (() => new URL('./hash-foo.svg', import.meta.url).href)()

console.log(foo);
// foo.hash-foo.png

importMode: 'url' output

import foo from './foo.hash-foo.png'
console.log(foo)
// foo.hash-foo.png

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify Netlify
Copy link

netlify bot commented Sep 21, 2025 •
edited
Loading

✅ Deploy Preview for rspack ready!

Name Link
🔨 Latest commit e33eaea
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/68d2cb177118dd000811810d
😎 Deploy Preview https://deploy-preview-11725--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: feature release: feature related release(mr only) labels Sep 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 21, 2025 •
edited
Loading

📦 Binary Size-limit

Comparing e33eaea to fix: correct infrastructureLog type and add documentation (#11742) by neverland

❌ Size increased by 1.00KB from 47.43MB to 47.43MB (⬆️0.00%)

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 21, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #11725 will not alter performance

Comparing syt/asset-new-url (e33eaea) with main (786ffea)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 17 untouched

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardfist hardfist Awaiting requested review from hardfist hardfist will be requested when the pull request is marked ready for review hardfist is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SoonIter