Why preview mode runs rsbuild flow anyway?

[JounQin]

rspress/packages/cli/src/index.ts

Line 140 in e2ebf7a

config,

There is no root argument to override config.root in preview command like build, so I'd expect that preview should only serve doc_build dir orconfig.outDir directly.

rspress/packages/core/src/node/serve.ts

Lines 36 to 41 in e2ebf7a

	const builder = await initRsbuild(
	config.root,
	modifiedConfig,
	pluginDriver,
	false,
	);

I don't follow why the whole rsbuild flow should be invoked, that seems just wasting?

[Timeless0911]

Using existing preview features of Rsbuild can make it easy to maintain, you can serve it yourself on your demand.

[Timeless0911]

Is there a minimal reproduce repository?

[chenjiahan]

I do not agree with removing all plugins during the preview. Running plugins to modify the config during preview is allowed, and it does not have a significant performance impact. I checked that the Vite plugin also runs during vite preview.

[JounQin]

Running plugins to modify the config during preview is allowed

I don't quite understand the use case, I was thinking preview only serves static doc_build dir, anything else? If so, no [root] argument provided may cause inconsistent behavior with build command.

---

I noticed this issue because it says root is optional in config which defaults as docs at https://rspress.dev/api/config/config-basic#root, but actually it's required in some core plugins like @rspress/plugin-auto-nav-sidebar as I mentioned at #1458 (reply in thread)

The reproduction is just simple: https://github.com/JounQin/rspress-preview-issue/blob/main/cli.ts

[Timeless0911]

This may be a bug related to config.root, I will fix it later and add a [root] argument to preview command.

[Timeless0911]

You can use [email protected] to verify the behaviour now, the PR is #1461