refactor: replace globby with tinyglob, govern execa, chalk #1773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aquamarine-blini-95325f ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Timeless0911
previously approved these changes
Jan 25, 2025
chenjiahan
reviewed
Jan 25, 2025
Member
chenjiahan
left a comment
chenjiahan
left a comment
There was a problem hiding this comment.
Do not forget to add some PR descriptions
SoonIter
changed the title
SoonIter
changed the title
SoonIter
changed the title
Timeless0911
approved these changes
Jan 26, 2025
This was referenced Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
At present, the prebundled packages are difficultly to be migrated to Rslib because they are needless, and should be bundled by prebundle)
wanna remove @rspress/shared, and move the prebundled packages into @rspress/core just like Rsbuild repo
these are some small tasks for this target below
replace globby with tinyglob (remove the copied prebundled packages in @rspack/core perf: optimize dependencies size #437)
remove execa from @rspress/shared
remove chalk in cli from dependencies
Related Issue
#437
web-infra-dev/rslib#307
Checklist