clean

Author: fi3ework

e2e/scripts/index.ts

@@ -11,7 +11,6 @@ class Cli {
   public stdout = '';
   public stderr = '';
   private stdoutListeners: Array<() => void> = [];
-  // biome-ignore lint/correctness/noUnusedPrivateClassMembers: will use it
   private stderrListeners: Array<() => void> = [];
 
   constructor(

e2e/test-coverage/fixtures/src/string.ts

@@ -21,5 +21,5 @@ export const countWords = (str: string): number => {
 
 export const truncate = (str: string, maxLength: number): string => {
   if (str.length <= maxLength) return str;
-  return str.slice(0, maxLength - 3) + '...';
+  return `${str.slice(0, maxLength - 3)}...`;
 };

packages/vscode/AGENTS.md

@@ -1,16 +1,16 @@
-# Repository Guidelines
+# Repository guidelines
 
 Concise contributor guide for the Rstest VS Code extension package.
 
-## Project Structure & Module Organization
+## Project structure & module organization
 
 - `src/` — TypeScript sources. Key modules: `extension.ts` (entry/TestController), `testTree.ts` (builds TestItem tree), `parserTest.ts` (SWC-based parser), `master.ts` (spawns worker), `worker/` (runner + reporter).
 - `tests/` — E2E tests under `tests/suite/**`. Compiled to `tests-dist/` for the Extension Host.
 - `tests/unit/**` — Unit tests executed by `@rstest/core` with fixtures in `tests/unit/fixtures`.
 - `dist/` — Built extension output. Do not edit.
 - Config: `tsconfig.json`, `tsconfig.test.json`, `rslib.config.ts`, `rstest.config.ts`.
 
-## Build, Test, and Development Commands
+## Build, test, and development commands
 
 - `npm run build` — Build with `rslib` (use `build:local` for sourcemaps).
 - `npm run watch` — Rebuild on change.
@@ -19,25 +19,25 @@ Concise contributor guide for the Rstest VS Code extension package.
 - `npm run test:e2e` — Compile tests and run VS Code Extension Host E2E (downloads VS Code on first run).
 - `npm run lint` — Run Biome checks.
 
-## Coding Style & Naming Conventions
+## Coding style & naming conventions
 
 - Language: TypeScript, 2-space indentation. Keep changes minimal and focused.
 - Naming: camelCase for files and symbols; PascalCase for classes; follow existing patterns (e.g., `testTree.ts`, `parserTest.ts`).
 - Linting: Biome (`npm run lint`). Prefer simple, readable logic over cleverness.
 
-## Testing Guidelines
+## Testing guidelines
 
 - Name tests `*.test.ts`. Place parser/unit tests in `tests/unit/**`; E2E tests in `tests/suite/**` (loaded by the E2E runner only).
 - E2E opens `tests/fixtures` workspace automatically; use `toLabelTree()` from `tests/suite/index.test.ts` for stable tree assertions.
 - Typical loop: `npm run typecheck` → `npm run test:unit` → `npm run test:e2e`.
 
-## Commit & Pull Request Guidelines
+## Commit & pull request guidelines
 
 - Write clear, imperative commit messages; keep PRs small and scoped. Reference issues (e.g., `Fixes #123`).
 - Include rationale, testing notes, and screenshots/logs if relevant (e.g., label trees, error output).
 - Avoid unrelated refactors; update or add tests with behavior changes.
 
-## Architecture Overview
+## Architecture overview
 
 - Two-process design: VS Code extension (`extension.ts`) communicates with a worker (`worker/index.ts`) via WebSocket. Main sends `WorkerInitData`/`WorkerRunTestData`; worker emits `WorkerEventFinish`.
 

packages/vscode/README.md

@@ -19,7 +19,7 @@ The extension activates automatically when your workspace contains Rstest config
 | ---------------------------- | -------- | -------- | -------------------------------- | ------------------------------------------------------------- |
 | `rstest.testFileGlobPattern` | string[] | Resource | `["**/*.test.*", "**/*.spec.*"]` | Glob pattern(s) used to discover test files in the workspace. |
 
-## How it Works
+## How it works
 
 - On activation, the extension scans for test files using `rstest.testFileGlobPattern` and creates a Test Explorer tree.
 - File system watchers keep the tree synchronized as files are created, modified, or deleted.
@@ -35,11 +35,12 @@ Common commands (run from this package):
 - `npm run test:unit` — Unit tests via Rstest
 - `npm run test:e2e` — VS Code Extension Host E2E tests
 
-### Packaging & Publishing
+### Packaging & publishing
 
 - Local package (current platform): `npm run package:vsix`
 - Publish (current platform): `npm run publish:vsce` (requires `VSCE_PAT`)
 
 CI
+
 - On tag push or manual dispatch, GitHub Actions runs on Linux and publishes for all platforms using `vsce publish --target` (win32/darwin/linux; x64 and arm64).
 - Configure the `VSCE_PAT` repository secret for Marketplace publishing.

packages/vscode/src/extension.ts

@@ -231,34 +231,6 @@ class Rstest {
       }
     };
 
-    // const runTestQueue = async () => {
-    //   for (const { test, data } of queue) {
-    //     run.appendOutput(`Running ${test.id}\r\n`);
-    //     if (run.token.isCancellationRequested) {
-    //       run.skipped(test);
-    //     } else {
-    //       run.started(test);
-    //       await data.run(test, run, this.api);
-    //     }
-
-    //     const lineNo = test.range!.start.line;
-    //     const fileCoverage = coveredLines.get(test.uri!.toString());
-    //     const lineInfo = fileCoverage?.[lineNo];
-    //     if (lineInfo) {
-    //       (lineInfo.executed as number)++;
-    //     }
-
-    //     run.appendOutput(`Completed ${test.id}\r\n`);
-    //   }
-
-    //   // TODO: support coverage in the future
-    //   // for (const [uri, statements] of coveredLines) {
-    //   //   run.addCoverage(new MarkdownFileCoverage(uri, statements));
-    //   // }
-
-    //   run.end();
-    // };
-
     discoverTests(request.include ?? gatherTestItems(this.ctrl.items))
       .then(() => run.end())
       .catch((error) => {
@@ -279,12 +251,6 @@ class Rstest {
 
     return;
   }
-
-  // async initialize(context: vscode.ExtensionContext) {
-  //   context.subscriptions.push(
-  //     ...startWatchingWorkspace(this.ctrl, this.fileChangedEmitter),
-  //   );
-  // }
 }
 
 function getOrCreateFile(controller: vscode.TestController, uri: vscode.Uri) {

packages/vscode/src/logger.ts

@@ -50,7 +50,9 @@ export class Logger implements vscode.Disposable {
   }
 
   public dispose() {
-    this.disposables.forEach((disposable) => disposable.dispose());
+    this.disposables.forEach((disposable) => {
+      disposable.dispose();
+    });
     this.channel.dispose();
   }
 

packages/vscode/src/master.ts

@@ -5,13 +5,12 @@ import getPort from 'get-port';
 import vscode from 'vscode';
 import type { WebSocket } from 'ws';
 import { WebSocketServer } from 'ws';
-
+import { logger } from './logger';
 import type {
   WorkerEvent,
   WorkerEventFinish,
   WorkerRunTestData,
 } from './types';
-import { logger } from './logger';
 
 export class RstestApi {
   public ws: WebSocket | null = null;
@@ -137,6 +136,10 @@ export class RstestApi {
     const workerPath = path.resolve(__dirname, 'worker.js');
     const port = await getPort();
     const wsAddress = `ws://localhost:${port}`;
+    logger.debug('Spawning worker process', {
+      workerPath,
+      wsAddress,
+    });
     const rstestProcess = spawn('node', [...execArgv, workerPath], {
       stdio: 'pipe',
       env: {
@@ -148,19 +151,20 @@ export class RstestApi {
 
     rstestProcess.stdout?.on('data', (d) => {
       const content = d.toString();
-      logger.debug('🟢 worker', content.trimEnd());
+      logger.debug('worker stdout', content.trimEnd());
     });
 
     rstestProcess.stderr?.on('data', (d) => {
       const content = d.toString();
-      logger.error('🔴 worker', content.trimEnd());
+      logger.error('worker stderr', content.trimEnd());
     });
 
     const server = createServer().listen(port).unref();
     const wss = new WebSocketServer({ server });
 
     wss.once('connection', (ws) => {
       this.ws = ws;
+      logger.debug('Worker connected', { wsAddress });
       const { cwd, rstestPath } = this.resolveRstestPath()[0];
       ws.send(
         JSON.stringify({
@@ -169,11 +173,21 @@ export class RstestApi {
           cwd,
         }),
       );
+      logger.debug('Sent init payload to worker', { cwd, rstestPath });
 
       ws.on('message', (_data) => {
         const _message = JSON.parse(_data.toString()) as WorkerEvent;
         if (_message.type === 'finish') {
           const message: WorkerEventFinish = _message;
+          logger.debug('Received worker completion event', {
+            id: message.id,
+            testResultCount: Array.isArray(message.testResults)
+              ? message.testResults.length
+              : undefined,
+            testFileResultCount: Array.isArray(message.testFileResults)
+              ? message.testFileResults.length
+              : undefined,
+          });
           // Check if we have a pending promise for this test ID
           const promiseObj = this.testPromises.get(message.id);
           if (promiseObj) {
@@ -186,7 +200,9 @@ export class RstestApi {
       });
     });
 
-    rstestProcess.on('exit', () => {});
+    rstestProcess.on('exit', (code, signal) => {
+      logger.debug('Worker process exited', { code, signal });
+    });
   }
 
   public async createRstestWorker() {}