Set kind: feature at runtime, for author convenience

ddbeck · ddbeck · commit 6ad4e80820b7 · 2025-07-22T20:15:10.000+02:00
diff --git a/features/conic-gradients.yml.dist b/features/conic-gradients.yml.dist
@@ -1,7 +1,6 @@
 # Generated from: conic-gradients.yml
 # Do not edit this file by hand. Edit the source file instead!
 
-kind: feature
 status:
   baseline: high
   baseline_low_date: 2020-11-17
diff --git a/features/gradients.yml.dist b/features/gradients.yml.dist
@@ -1,7 +1,6 @@
 # Generated from: gradients.yml
 # Do not edit this file by hand. Edit the source file instead!
 
-kind: feature
 status:
   baseline: high
   baseline_low_date: 2015-07-29
diff --git a/features/numeric-separators.yml.dist b/features/numeric-separators.yml.dist
@@ -1,7 +1,6 @@
 # Generated from: numeric-separators.yml
 # Do not edit this file by hand. Edit the source file instead!
 
-kind: feature
 status:
   baseline: high
   baseline_low_date: 2020-07-28
diff --git a/index.ts b/index.ts
@@ -129,6 +129,11 @@ for (const [key, data] of yamlEntries('features')) {
         continue;
     }
 
+    // Attach `kind: feature` to ordinary features
+    if (!isMoved(data) && !isSplit(data)) {
+        data.kind = "feature";
+    }
+
     // Convert markdown to text+HTML.
     if (data.description) {
         const { text, html } = convertMarkdown(data.description);
diff --git a/scripts/dist.ts b/scripts/dist.ts
@@ -339,7 +339,7 @@ function toDist(sourcePath: string): YAML.Document {
   }
 
   // Assemble and return the dist YAML.
-  const dist = new Document({ kind: "feature" });
+  const dist = new Document({});
 
   dist.commentBefore = [
     `Generated from: ${id}.yml`,
diff --git a/type-guards.ts b/type-guards.ts
@@ -5,7 +5,7 @@ export function isOrdinaryFeatureData(x: unknown): x is FeatureData {
 }
 
 export function isSplit(x: unknown): x is FeatureSplitData {
-  return typeof x === "object" && "kind" in x && x.kind === "moved";
+  return typeof x === "object" && "kind" in x && x.kind === "split";
 }
 
 export function isMoved(x: unknown): x is FeatureMovedData {

Original file line number	Diff line number	Diff line change
`@@ -339,7 +339,7 @@ function toDist(sourcePath: string): YAML.Document {`
`339`	`339`	`}`
`340`	`340`
`341`	`341`	`// Assemble and return the dist YAML.`
`342`		`- const dist = new Document({ kind: "feature" });`
	`342`	`+ const dist = new Document({});`
`343`	`343`
`344`	`344`	`dist.commentBefore = [`
`345`	`345`	`Generated from: ${id}.yml`,
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@ export function isOrdinaryFeatureData(x: unknown): x is FeatureData {`
`5`	`5`	`}`
`6`	`6`
`7`	`7`	`export function isSplit(x: unknown): x is FeatureSplitData {`
`8`		`- return typeof x === "object" && "kind" in x && x.kind === "moved";`
	`8`	`+ return typeof x === "object" && "kind" in x && x.kind === "split";`
`9`	`9`	`}`
`10`	`10`
`11`	`11`	`export function isMoved(x: unknown): x is FeatureMovedData {`