Skip to content

Commit 386129d

Browse files
author
Mirko Brodesser
authored
RFC 183: remove experimental dump_test_results function in <testharnessreport.js> (#192)
1 parent 669378f commit 386129d

File tree

1 file changed

+19
-0
lines changed

1 file changed

+19
-0
lines changed
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
# RFC 183: Remove experimental `dump_test_results` function in <testharnessreport.js>
2+
3+
## Summary
4+
That function is still called but the element it creates is never accessed. The created element contains stringified JSON of test result data.
5+
PR [^1] proposes to remove the function. It was added in 2015 with the comment "This is experimental until we have a better way to integrate with saucelabs".
6+
PR [^2] reduces the performance of the generating the test results' summary table which is consumed by `dump_test_results`.
7+
If that function is never used, degraded performance doesn't matter.
8+
9+
## Details
10+
See [^3] and [^4].
11+
12+
## Risks
13+
None known as the element generated from the function seems unused in WebKit, Gecko and Chromium; see [^3].
14+
It could be used in other downstream-projects, though.
15+
16+
[^1]: https://github.com/web-platform-tests/wpt/pull/45003
17+
[^2]: https://github.com/web-platform-tests/wpt/pull/45002
18+
[^3]: https://github.com/web-platform-tests/wpt/pull/45003#issue-2176117406
19+
[^4]: https://github.com/web-platform-tests/wpt/issues/44352#issuecomment-1985862862

0 commit comments

Comments
 (0)