[LayoutNG] Fix PDI/PDF not to affect line breaking

kojiishi · chromium-wpt-export-bot · commit 32fc57874bfa · 2019-08-04T12:14:09.000-04:00
This patch fixes PDI/PDF before spaces not to suppress the line breaking opportunity at the space. For example, before this fix, `<bdo dir=ltr>a</bdo> b` could not break between "a" and "b". PDI and PDF are injected by the `unicode-bidi` property, or elements that imply the `unicode-bidi` property such as `<bdi>`, `<bdo>`, or any elements with `dir` attributes. Bug: 989094 Change-Id: I2128774e2b062ecb86880812c54d46299a19a18a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735146 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#683881}
diff --git a/css/css-writing-modes/bidi-line-break-001.html b/css/css-writing-modes/bidi-line-break-001.html
@@ -0,0 +1,56 @@
+<!DOCTYPE html>
+<title>Test implicit bidi controls do not affect line breaking</title>
+<link rel="help" href="https://drafts.csswg.org/css-writing-modes-3/#unicode-bidi">
+<link rel="author" title="Koji Ishii" href="mailto:kojii@chromium.org">
+<style>
+html {
+  font-size: 10px;
+  line-height: 1;
+}
+.isolate {
+  unicode-bidi: isolate;
+}
+.embed {
+  unicode-bidi: embed;
+}
+</style>
+<script src="/resources/testharness.js"></script>
+<script src="/resources/testharnessreport.js"></script>
+<body>
+<div id=log></div>
+<div id="container">
+  <div style="width: 4ch" data-expected-height="20">
+    <span class="isolate" dir="ltr">00</span> <span class="isolate" dir="ltr">00</span>
+  </div>
+  <div style="width: 4ch" data-expected-height="20">
+    <span class="embed" dir="ltr">00</span> <span class="embed" dir="ltr">00</span>
+  </div>
+
+  <div style="width: 4ch" data-expected-height="20">
+    <span dir="ltr">00</span> <span dir="ltr">00</span>
+  </div>
+  <div style="width: 4ch" data-expected-height="20">
+    <bdi dir="ltr">00</bdi> <bdi dir="ltr">00</bdi>
+  </div>
+  <div style="width: 4ch" data-expected-height="20">
+    <bdo dir="ltr">00</bdo> <bdo dir="ltr">00</bdo>
+  </div>
+
+  <div style="width: 4ch" data-expected-height="20">
+    <span class="isolate" dir="ltr">00 </span><span class="isolate" dir="ltr">00</span>
+  </div>
+  <div style="width: 4ch" data-expected-height="20">
+    <span class="embed" dir="ltr">00 </span><span class="embed" dir="ltr">00</span>
+  </div>
+</div>
+<script>
+run();
+function run() {
+  for (let node of document.getElementById('container').children) {
+    test(() => {
+      assert_approx_equals(node.offsetHeight, 20, 1);
+    }, node.innerHTML);
+  }
+}
+</script>
+</body>
