Skip to content
This repository was archived by the owner on Mar 19, 2021. It is now read-only.

Commit 3ba499b

Browse files
Balazs Engedychromium-wpt-export-bot
authored andcommitted
Move the future back by 19 years.
The following cookie lifetime tests prophesied that 8am GMT 7th Aug 2019 would never arrive, but in hindsight this prediction turned out to be overly pessimistic, as evidenced by the tests failing across the board: external/wpt/cookies/http-state/comma-tests.html external/wpt/cookies/http-state/general-tests.html virtual/samesite-by-default-cookies/external/wpt/cookies/http-state/comma-tests.html virtual/samesite-by-default-cookies/external/wpt/cookies/http-state/general-tests.html This CL redefines the future as the very first second of the year 2038, which is admittedly a couple of days earlier than when the world will actually end, but is hopefully a good enough approximation as it seems unlikely that in those final days it will be anybody's primary concern that these tests are failing. Bug: None Change-Id: I4dcebedecb802785fbd494b864bc2cbbf8f66718 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741811 Reviewed-by: Balazs Engedy <[email protected]> Reviewed-by: Friedrich [CET] <[email protected]> Commit-Queue: Balazs Engedy <[email protected]> Cr-Commit-Position: refs/heads/master@{#684712}
1 parent 66b4fab commit 3ba499b

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Set-Cookie: foo=bar; Expires=Fri, 07 Aug 2019 08:04:19 GMT
1+
Set-Cookie: foo=bar; Expires=Fri, 01 Jan 2038 00:00:00 GMT
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Set-Cookie: foo=bar; Expires=Fri, 07 Aug 2019 08:04:19 GMT
1+
Set-Cookie: foo=bar; Expires=Fri, 01 Jan 2038 00:00:00 GMT
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Set-Cookie: foo=bar; Expires=Fri 07 Aug 2019 08:04:19 GMT, baz=qux
1+
Set-Cookie: foo=bar; Expires=Fri 01 Jan 2038 00:00:00 GMT, baz=qux

0 commit comments

Comments
 (0)