[LayoutNG] Allow clearance as a valid value in the new-fc DCHECK.

bfgeek · chromium-wpt-export-bot · commit 4365c77bd403 · 2019-08-06T15:30:16.000-04:00
Patch: https://chromium-review.googlesource.com/c/chromium/src/+/1692627 Made us consider inline-level OOF-positioned nodes as adjoining, as their static-position depends on where other floats are placed. During the first pass the BFC block-offset gets resolved here: https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/layout/ng/ng_block_layout_algorithm.cc?l=986&rcl=e6157bb7afb778d5c15bb2bb09a457d9632151da This aborts as it has an adjoining inline-OOF, and *doesn't* resolve the BFC block-offset at |child_bfc_offset_estimate| instead applying clearance. Upon the second pass we now hit the DCHECK as neither of the options has clearance applied. Bug: 987004 Change-Id: I2634d56726a4664c869b2ecfa1e7a8a13458e78f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731917 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#684426}
diff --git a/css/CSS2/floats-clear/adjoining-float-new-fc-crash.html b/css/CSS2/floats-clear/adjoining-float-new-fc-crash.html
@@ -0,0 +1,16 @@
+<!DOCTYPE html>
+<script src="/resources/testharness.js"></script>
+<script src="/resources/testharnessreport.js"></script>
+<link rel="help" href="https://bugs.chromium.org/p/chromium/issues/detail?id=987004">
+<meta name="assert" content="The renderer should not crash.">
+<div style="width: 100px; overflow: hidden;">
+  <div style="float: left; width: 100%; height: 20px; background: hotpink;"></div>
+  <div style="clear: both;">
+    <span style="position: absolute; width: 10px; height: 10px; background: orange;"></span>
+    <div style="height: 10px; background: green; overflow: hidden;"></div>
+  </div>
+</div>
+<script>
+test(() => {
+}, 'Test passes if the renderer does not crash.');
+</script>
