You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Mar 19, 2021. It is now read-only.
with: https://chromium-review.googlesource.com/c/chromium/src/+/1554113
We introduced a new flag for SelfNeedsLayoutForAvailableSpace. For any
alignment change this was set to true for grid-items.
SelfNeedsLayout reports true if this flag is set, or if the normal
SelfNeedsLayoutForStyle is true.
This caused an issue where we weren't performing layout on the whole tree
however.
If a child of the grid-item (whose alignment changed) was marked for
needing style-layout, it would try and mark its container chain for
layout, hit the grid item, and abort, as it already "needed" layout.
Within NG we'd come across the grid-item, hit the cache, or perform
simplified layout, never clearing layout, having a bad ptr, etc.
This is a conservative fix so that this can be merged.
Bug: 991446
Change-Id: I75edebc864eb470ebfad757966ddc0e0248de153
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741439
Commit-Queue: Ian Kilpatrick <[email protected]>
Commit-Queue: Emil A Eklund <[email protected]>
Auto-Submit: Ian Kilpatrick <[email protected]>
Reviewed-by: Emil A Eklund <[email protected]>
Cr-Commit-Position: refs/heads/master@{#684966}
0 commit comments