Skip to content
This repository was archived by the owner on Mar 19, 2021. It is now read-only.

Commit a4ddde6

Browse files
annevkjgraham
authored andcommitted
Documentation: .serviceworker implies .https these days (#18295)
See discussion at web-platform-tests/wpt#18228.
1 parent aecedb5 commit a4ddde6

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

docs/writing-tests/file-names.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,8 @@ themselves precede any test type flag, but are otherwise unordered.
5858
context why the test is tentative and what needs to be resolved to make it
5959
non-tentative.
6060

61+
It's preferable that `.window`, `.worker`, and `.any` are immediately followed
62+
by their final `.js` extension.
6163

6264
[server-side substitution]: https://wptserve.readthedocs.io/en/latest/pipes.html#sub
6365
[RFC 2119]: https://tools.ietf.org/html/rfc2119

docs/writing-tests/general-guidelines.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,8 @@ css/ directory, regardless of where they are in the directory structure.
3232

3333
By default, tests are served over plain HTTP. If a test requires HTTPS
3434
it must be given a filename containing `.https` before the extension,
35-
e.g. `test-secure.https.html`. For more details see the documentation
35+
e.g., `test-secure.https.html`, or be the generated service worker test
36+
of a `.https`-less `.any` test. For more details see the documentation
3637
on [file names][file-name-flags].
3738

3839
#### Support Files

docs/writing-tests/testharness.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ are:
165165

166166
* `window` (default): to be run at <code><var>x</var>.any.html</code>
167167
* `dedicatedworker` (default): to be run at <code><var>x</var>.any.worker.html</code>
168-
* `serviceworker`: to be run at <code><var>x</var>.https.any.serviceworker.html</code>
168+
* `serviceworker`: to be run at <code><var>x</var>.any.serviceworker.html</code> (`.https` is implied)
169169
* `sharedworker`: to be run at <code><var>x</var>.any.sharedworker.html</code>
170170
* `jsshell`: to be run in a JavaScript shell, without access to the DOM
171171
(currently only supported in SpiderMonkey, and skipped in wptrunner)

0 commit comments

Comments
 (0)