Skip to content
This repository was archived by the owner on Mar 19, 2021. It is now read-only.

Commit ceedf0a

Browse files
andreasttjgraham
authored andcommitted
webdriver: make collection tests count <meta
The HTML boilerplate now includes a <meta charset=utf-8> element, and the Execute (Async) Script collection tests must include this in its checks. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1570302 gecko-commit: 21696af2ddec0568c1f8bb08768d283c73b0c813 gecko-integration-branch: mozilla-inbound gecko-reviewers: whimboo
1 parent 6fdb04a commit ceedf0a

File tree

2 files changed

+14
-10
lines changed

2 files changed

+14
-10
lines changed

webdriver/tests/execute_async_script/collections.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ def test_html_all_collection(session):
6363
""")
6464
html = session.find.css("html", all=False)
6565
head = session.find.css("head", all=False)
66+
meta = session.find.css("meta", all=False)
6667
body = session.find.css("body", all=False)
6768
ps = session.find.css("p")
6869

@@ -72,14 +73,15 @@ def test_html_all_collection(session):
7273
""")
7374
value = assert_success(response)
7475
assert isinstance(value, list)
75-
# <html>, <head>, <body>, <p>, <p>
76-
assert len(value) == 5
76+
# <html>, <head>, <meta>, <body>, <p>, <p>
77+
assert len(value) == 6
7778

7879
assert_same_element(session, html, value[0])
7980
assert_same_element(session, head, value[1])
80-
assert_same_element(session, body, value[2])
81-
assert_same_element(session, ps[0], value[3])
82-
assert_same_element(session, ps[1], value[4])
81+
assert_same_element(session, meta, value[2])
82+
assert_same_element(session, body, value[3])
83+
assert_same_element(session, ps[0], value[4])
84+
assert_same_element(session, ps[1], value[5])
8385

8486

8587
def test_html_collection(session):

webdriver/tests/execute_script/collections.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,20 +56,22 @@ def test_html_all_collection(session):
5656
""")
5757
html = session.find.css("html", all=False)
5858
head = session.find.css("head", all=False)
59+
meta = session.find.css("meta", all=False)
5960
body = session.find.css("body", all=False)
6061
ps = session.find.css("p")
6162

6263
response = execute_script(session, "return document.all")
6364
value = assert_success(response)
6465
assert isinstance(value, list)
65-
# <html>, <head>, <body>, <p>, <p>
66-
assert len(value) == 5
66+
# <html>, <head>, <meta>, <body>, <p>, <p>
67+
assert len(value) == 6
6768

6869
assert_same_element(session, html, value[0])
6970
assert_same_element(session, head, value[1])
70-
assert_same_element(session, body, value[2])
71-
assert_same_element(session, ps[0], value[3])
72-
assert_same_element(session, ps[1], value[4])
71+
assert_same_element(session, meta, value[2])
72+
assert_same_element(session, body, value[3])
73+
assert_same_element(session, ps[0], value[4])
74+
assert_same_element(session, ps[1], value[5])
7375

7476

7577
def test_html_collection(session):

0 commit comments

Comments
 (0)