[triage] Allow the triaging of a test, unrelated to a product

This adds support for triaging a test unrelated to a product (e.g.
Chrome). The goal is to allow the triaging of tests that are problematic
due to the test itself (e.g. if the test violates the spec or has bugs),
rather than problematic due to a browser bug.

To achieve this without changing the current data model, we use the
current support for an empty product. This is currently unused, but was
meant to be for URLs that affect all tests so matches well to the new
use-case. Metadata for this case are shown next to the test name rather
than in the results boxes, and similarly one triages test issues by
selecting the test name cell.

Author: stephenmcgruer

webapp/components/product-info.js

@@ -142,6 +142,14 @@ const ProductInfo = (superClass) => class extends superClass {
     return '';
   }
 
+  displayMetadataLogo(productName) {
+    // Special case for metadata; an empty product name maps to the WPT logo.
+    if (productName === '') {
+      productName = 'wpt';
+    }
+    return this.displayLogo(productName);
+  }
+
   displayLogo(name, labels) {
     if (!name) {
       return;

webapp/components/test/product-info.html

@@ -42,6 +42,11 @@
     expect(productInfo.displayLabels(['foo', 'bar'])).to.equal('foo, bar');
   });
 
+  test('displayMetadataLogo', () => {
+    expect(productInfo.displayMetadataLogo('')).to.equal('/static/wpt_64x64.png');
+    expect(productInfo.displayMetadataLogo('chrome')).to.equal('/static/chrome_64x64.png');
+  });
+
   test('displayLogo', () => {
     expect(productInfo.displayLogo(undefined, undefined)).to.equal(undefined);
     expect(productInfo.displayLogo('browser', undefined)).to.equal('/static/browser_64x64.png');

webapp/components/test/wpt-amend-metadata.html

@@ -81,6 +81,19 @@
 
       assert.deepEqual(appFixture.getTriagedMetadataMap(displayedMetadata), expected);
     });
+    test('getTriagedMetadataMap(displayedMetadata) for a test-level triage', () => {
+      appFixture.path = '/abc';
+      const displayedMetadata = [
+        { product: '', url: 'foo', tests: ['testA.html'] },
+      ];
+      // When there is no product, we have to remove the product from the
+      // metadata map for calling into /api/metadata/triage.
+      const expected = {
+        'testA.html': [{ url: 'foo' }],
+      };
+
+      assert.deepEqual(appFixture.getTriagedMetadataMap(displayedMetadata), expected);
+    });
     test('getTriagedMetadataMap(displayedMetadata) with a testfile path', () => {
       appFixture.path = '/abc/foo.html';
       const displayedMetadata = [
@@ -144,4 +157,4 @@
 </script>
 </body>
 
-</html>
+</html>

webapp/components/wpt-amend-metadata.js

@@ -158,7 +158,7 @@ class AmendMetadata extends LoadingState(PathInfo(ProductInfo(PolymerElement)))
         <paper-dialog-scrollable>
           <template is="dom-repeat" items="[[displayedMetadata]]" as="node">
             <div class="metadata-entry">
-              <img class="browser" src="[[displayLogo(node.product)]]">
+              <img class="browser" src="[[displayMetadataLogo(node.product)]]">
               :
               <paper-input label="Bug URL" value="{{node.url}}" autofocus></paper-input>
             </div>
@@ -252,7 +252,11 @@ class AmendMetadata extends LoadingState(PathInfo(ProductInfo(PolymerElement)))
           if (!(test in link)) {
             link[test] = [];
           }
-          link[test].push({ 'url': entry.url, 'product': entry.product });
+          const metadata = { 'url': entry.url };
+          if (entry.product !== '') {
+            metadata['product'] = entry.product;
+          }
+          link[test].push(metadata);
         }
       }
     }

webapp/components/wpt-metadata.js

@@ -42,7 +42,7 @@ class WPTMetadataNode extends ProductInfo(PolymerElement) {
         <iron-icon class="bug" icon="bug-report"></iron-icon>
         <div>
           <a href="[[testHref]]" target="_blank">[[metadataNode.test]]</a> >
-          <img class="browser" src="[[displayLogo(metadataNode.product)]]"> :
+          <img class="browser" src="[[displayMetadataLogo(metadataNode.product)]]"> :
           <a href="[[metadataNode.url]]" target="_blank">[[metadataNode.url]]</a>
           <br />
         </div>

webapp/static/wpt_64x64.png

@@ -226,8 +226,13 @@ class WPTResults extends AmendMetadataMixin(Pluralizer(WPTColors(WPTFlags(PathIn
                     </template>
                   </template>
                 </td>
-                <td>
+                <td onclick="[[handleTriageSelect(null, node, testRun)]]" onmouseover="[[handleTriageHover(null, node, testRun)]]">
                   <path-part prefix="/results" path="{{ node.path }}" query="{{ query }}" is-dir="{{ node.isDir }}"></path-part>
+                  <template is="dom-if" if="[[shouldDisplayMetadata(null, node.path, metadataMap)]]">
+                    <a href="[[ getMetadataUrl(null, node.path, metadataMap) ]]" target="_blank">
+                      <iron-icon class="bug" icon="bug-report"></iron-icon>
+                    </a>
+                  </template>
                 </td>
 
                 <template is="dom-repeat" items="{{testRuns}}" as="testRun">
@@ -871,6 +876,12 @@ class WPTResults extends AmendMetadataMixin(Pluralizer(WPTColors(WPTFlags(PathIn
   }
 
   canAmendMetadata(node, index, testRun) {
+    // It is always possible in triage mode to amend metadata for a problem
+    // with a test file itself.
+    if (index === undefined) {
+      return !node.isDir && this.triageMetadataUI && this.isTriageMode;
+    }
+
     const totalTests = this.getNodeResultDataByPropertyName(node, index, testRun, 'total');
     const passedTests = this.getNodeResultDataByPropertyName(node, index, testRun, 'passes');
     return (totalTests - passedTests) > 0 && this.triageMetadataUI && this.isTriageMode;
@@ -1044,7 +1055,8 @@ class WPTResults extends AmendMetadataMixin(Pluralizer(WPTColors(WPTFlags(PathIn
         return;
       }
 
-      this.handleSelect(e.target.closest('td'), this.displayedProducts[index].browser_name, node.path, this.$['selected-toast']);
+      const product = index === undefined ? '' : this.displayedProducts[index].browser_name;
+      this.handleSelect(e.target.closest('td'), product, node.path, this.$['selected-toast']);
     };
   }
 
@@ -1065,13 +1077,14 @@ class WPTResults extends AmendMetadataMixin(Pluralizer(WPTColors(WPTFlags(PathIn
       testname = testname + '/*';
     }
 
-    const key = testname + this.displayedProducts[index].browser_name;
+    const browserName = index === undefined ? '' : this.displayedProducts[index].browser_name;
+    const key = testname + browserName;
     if (key in metadataMap) {
       if ('/' in metadataMap[key]) {
         return metadataMap[key]['/'];
       }
 
-      // If a URL link does not exit on a test level, return the first subtest link.
+      // If a URL link does not exist on a test level, return the first subtest link.
       const subtestMap = metadataMap[key];
       return subtestMap[Object.keys(subtestMap)[0]];
     }