Upgrade to go-github v33 (#2405)

KyleJu · Kyle Ju · web-flow · commit 4fba59edb14e · 2021-02-18T18:43:21.000-05:00
* Upgrade to go-github v33

* Remove HeadSHA

Co-authored-by: Kyle Ju &lt;kyleju@chromium.org&gt;
diff --git a/api/checks/api.go b/api/checks/api.go
@@ -12,7 +12,7 @@ import (
 	"net/url"
 	"time"
 
-	"github.com/google/go-github/v32/github"
+	"github.com/google/go-github/v33/github"
 	"github.com/web-platform-tests/wpt.fyi/api/checks/summaries"
 	"github.com/web-platform-tests/wpt.fyi/shared"
 )
diff --git a/api/checks/jwt.go b/api/checks/jwt.go
@@ -17,7 +17,7 @@ import (
 	"time"
 
 	jwt "github.com/dgrijalva/jwt-go"
-	"github.com/google/go-github/v32/github"
+	"github.com/google/go-github/v33/github"
 	"github.com/web-platform-tests/wpt.fyi/shared"
 	"golang.org/x/oauth2"
 )
diff --git a/api/checks/mock_checks/api_mock.go b/api/checks/mock_checks/api_mock.go
diff --git a/api/checks/runs.go b/api/checks/runs.go
@@ -9,7 +9,7 @@ import (
 	"fmt"
 	"time"
 
-	"github.com/google/go-github/v32/github"
+	"github.com/google/go-github/v33/github"
 	"github.com/web-platform-tests/wpt.fyi/api/checks/summaries"
 	"github.com/web-platform-tests/wpt.fyi/shared"
 )
@@ -88,8 +88,8 @@ func getExistingCheckRuns(ctx context.Context, suite shared.CheckSuite) ([]*gith
 	}
 
 	var runs []*github.CheckRun
-	options := github.ListCheckRunsOptions {
-		ListOptions: github.ListOptions {
+	options := github.ListCheckRunsOptions{
+		ListOptions: github.ListOptions{
 			// 100 is the maximum allowed items per page; see
 			// https://developer.github.com/v3/guides/traversing-with-pagination/#changing-the-number-of-items-received
 			PerPage: 100,
@@ -135,7 +135,6 @@ func updateExistingCheckRunSummary(ctx context.Context, summary summaries.Summar
 	title := state.Title()
 	opts := github.UpdateCheckRunOptions{
 		Name:       state.Name(),
-		HeadSHA:    &state.HeadSHA,
 		DetailsURL: &detailsURLStr,
 		Status:     &state.Status,
 		Conclusion: state.Conclusion,
diff --git a/api/checks/summaries/actions.go b/api/checks/summaries/actions.go
@@ -4,7 +4,7 @@
 
 package summaries
 
-import "github.com/google/go-github/v32/github"
+import "github.com/google/go-github/v33/github"
 
 // RecomputeAction is an action that can be taken to
 // trigger a recompute of the diff, against the latest
diff --git a/api/checks/summaries/actions_test.go b/api/checks/summaries/actions_test.go
@@ -9,7 +9,7 @@ package summaries
 import (
 	"testing"
 
-	"github.com/google/go-github/v32/github"
+	"github.com/google/go-github/v33/github"
 	"github.com/stretchr/testify/assert"
 )
 
diff --git a/api/checks/summaries/compile.go b/api/checks/summaries/compile.go
@@ -16,7 +16,7 @@ import (
 	mapset "github.com/deckarep/golang-set"
 	"github.com/gobuffalo/packr/v2"
 
-	"github.com/google/go-github/v32/github"
+	"github.com/google/go-github/v33/github"
 	"github.com/web-platform-tests/wpt.fyi/shared"
 )
 
diff --git a/api/checks/summaries/completed.go b/api/checks/summaries/completed.go
@@ -5,7 +5,7 @@
 package summaries
 
 import (
-	"github.com/google/go-github/v32/github"
+	"github.com/google/go-github/v33/github"
 	"github.com/web-platform-tests/wpt.fyi/shared"
 )
 
diff --git a/api/checks/summaries/pending.go b/api/checks/summaries/pending.go
@@ -4,7 +4,7 @@
 
 package summaries
 
-import "github.com/google/go-github/v32/github"
+import "github.com/google/go-github/v33/github"
 
 // Pending is the struct for pending.md.
 type Pending struct {
diff --git a/api/checks/summaries/regressed.go b/api/checks/summaries/regressed.go
@@ -5,7 +5,7 @@
 package summaries
 
 import (
-	"github.com/google/go-github/v32/github"
+	"github.com/google/go-github/v33/github"
 	"github.com/web-platform-tests/wpt.fyi/shared"
 )
 
diff --git a/api/checks/webhook.go b/api/checks/webhook.go
@@ -11,7 +11,7 @@ import (
 	"net/http"
 	"regexp"
 
-	"github.com/google/go-github/v32/github"
+	"github.com/google/go-github/v33/github"
 	"github.com/web-platform-tests/wpt.fyi/shared"
 )
 
diff --git a/api/checks/webhook_test.go b/api/checks/webhook_test.go
@@ -11,7 +11,7 @@ import (
 	"testing"
 
 	"github.com/golang/mock/gomock"
-	"github.com/google/go-github/v32/github"
+	"github.com/google/go-github/v33/github"
 	"github.com/stretchr/testify/assert"
 	"github.com/web-platform-tests/wpt.fyi/api/checks/mock_checks"
 	"github.com/web-platform-tests/wpt.fyi/shared"
diff --git a/api/manifest/api.go b/api/manifest/api.go
@@ -14,7 +14,7 @@ import (
 	"regexp"
 	"time"
 
-	"github.com/google/go-github/v32/github"
+	"github.com/google/go-github/v33/github"
 	"github.com/web-platform-tests/wpt.fyi/shared"
 )
 
diff --git a/api/metadata_cache.go b/api/metadata_cache.go
@@ -10,7 +10,7 @@ import (
 	"net/http"
 	"time"
 
-	"github.com/google/go-github/v32/github"
+	"github.com/google/go-github/v33/github"
 	"github.com/web-platform-tests/wpt.fyi/shared"
 )
 
diff --git a/api/prs.go b/api/prs.go
@@ -12,7 +12,7 @@ import (
 	"strings"
 	"time"
 
-	"github.com/google/go-github/v32/github"
+	"github.com/google/go-github/v33/github"
 	"github.com/web-platform-tests/wpt.fyi/shared"
 )
 
diff --git a/api/receiver/mock_receiver/api_mock.go b/api/receiver/mock_receiver/api_mock.go
diff --git a/api/taskcluster/mock_taskcluster/webhook_mock.go b/api/taskcluster/mock_taskcluster/webhook_mock.go
diff --git a/api/taskcluster/webhook.go b/api/taskcluster/webhook.go
@@ -17,7 +17,7 @@ import (
 	"sync"
 
 	mapset "github.com/deckarep/golang-set"
-	"github.com/google/go-github/v32/github"
+	"github.com/google/go-github/v33/github"
 	tcurls "github.com/taskcluster/taskcluster-lib-urls"
 	"github.com/taskcluster/taskcluster/v41/clients/client-go/tcqueue"
 	uc "github.com/web-platform-tests/wpt.fyi/api/receiver/client"
diff --git a/api/taskcluster/webhook_test.go b/api/taskcluster/webhook_test.go
@@ -19,7 +19,7 @@ import (
 	"time"
 
 	"github.com/golang/mock/gomock"
-	"github.com/google/go-github/v32/github"
+	"github.com/google/go-github/v33/github"
 	"github.com/stretchr/testify/assert"
 	uc "github.com/web-platform-tests/wpt.fyi/api/receiver/client"
 	tc "github.com/web-platform-tests/wpt.fyi/api/taskcluster"
@@ -574,8 +574,8 @@ func TestGetCheckSuiteEventInfo_sourceRepo(t *testing.T) {
 	defer mockC.Finish()
 	api := mock_tc.NewMockAPI(mockC)
 
-	runs := []*github.CheckRun {
-		&github.CheckRun {
+	runs := []*github.CheckRun{
+		&github.CheckRun{
 			Name:       strPtr("wpt-decision-task"),
 			Status:     strPtr("completed"),
 			DetailsURL: strPtr("https://community-tc.services.mozilla.com/tasks/Jq4HzLz0R2eKkJFdmf47Bg"),
@@ -616,7 +616,7 @@ func TestGetCheckSuiteEventInfo_sha(t *testing.T) {
 	defer mockC.Finish()
 	api := mock_tc.NewMockAPI(mockC)
 
-	runs := []*github.CheckRun {
+	runs := []*github.CheckRun{
 		&github.CheckRun{
 			Name:       strPtr("wpt-decision-task"),
 			Status:     strPtr("completed"),
@@ -652,7 +652,7 @@ func TestGetCheckSuiteEventInfo_master(t *testing.T) {
 	defer mockC.Finish()
 	api := mock_tc.NewMockAPI(mockC)
 
-	runs := []*github.CheckRun {
+	runs := []*github.CheckRun{
 		&github.CheckRun{
 			Name:       strPtr("wpt-decision-task"),
 			Status:     strPtr("completed"),
@@ -689,7 +689,7 @@ func TestGetCheckSuiteEventInfo_sender(t *testing.T) {
 	defer mockC.Finish()
 	api := mock_tc.NewMockAPI(mockC)
 
-	runs := []*github.CheckRun {
+	runs := []*github.CheckRun{
 		&github.CheckRun{
 			Name:       strPtr("wpt-decision-task"),
 			Status:     strPtr("completed"),
@@ -734,7 +734,7 @@ func TestGetCheckSuiteEventInfo_checkRuns(t *testing.T) {
 	//	the TaskGroupInfo:
 	//		TaskGroupID is the wpt-decision-tasks's taskID
 	//		Tasks is filled with each check_run's name, taskID, and status.
-	runs := []*github.CheckRun {
+	runs := []*github.CheckRun{
 		&github.CheckRun{
 			Name:       strPtr("wpt-decision-task"),
 			Status:     strPtr("completed"),
@@ -750,7 +750,6 @@ func TestGetCheckSuiteEventInfo_checkRuns(t *testing.T) {
 	}
 	api.EXPECT().ListCheckRuns(gomock.Any(), gomock.Any(), gomock.Any()).AnyTimes().Return(runs, nil)
 
-
 	event := github.CheckSuiteEvent{
 		CheckSuite: &github.CheckSuite{
 			HeadSHA: strPtr("abcdef123"),
diff --git a/go.mod b/go.mod
@@ -15,7 +15,7 @@ require (
 	github.com/gobuffalo/packr/v2 v2.8.1
 	github.com/golang/mock v1.4.4
 	github.com/gomodule/redigo v1.8.3
-	github.com/google/go-github/v32 v32.1.0
+	github.com/google/go-github/v33 v33.0.0
 	github.com/google/uuid v1.2.0
 	github.com/gorilla/handlers v1.5.1
 	github.com/gorilla/mux v1.8.0
diff --git a/go.sum b/go.sum
@@ -222,8 +222,8 @@ github.com/google/go-cmp v0.5.3/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/
 github.com/google/go-cmp v0.5.4 h1:L8R9j+yAqZuZjsqh/z+F1NCffTKKLShY6zXTItVIZ8M=
 github.com/google/go-cmp v0.5.4/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE=
 github.com/google/go-github/v27 v27.0.4/go.mod h1:/0Gr8pJ55COkmv+S/yPKCczSkUPIM/LnFyubufRNIS0=
-github.com/google/go-github/v32 v32.1.0 h1:GWkQOdXqviCPx7Q7Fj+KyPoGm4SwHRh8rheoPhd27II=
-github.com/google/go-github/v32 v32.1.0/go.mod h1:rIEpZD9CTDQwDK9GDrtMTycQNA4JU3qBsCizh3q2WCI=
+github.com/google/go-github/v33 v33.0.0 h1:qAf9yP0qc54ufQxzwv+u9H0tiVOnPJxo0lI/JXqw3ZM=
+github.com/google/go-github/v33 v33.0.0/go.mod h1:GMdDnVZY/2TsWgp/lkYnpSAh6TrzhANBBwm6k6TTEXg=
 github.com/google/go-querystring v1.0.0 h1:Xkwi/a1rcvNg1PPYe5vI8GbeBY/jrVuDX5ASuANWTrk=
 github.com/google/go-querystring v1.0.0/go.mod h1:odCYkC5MyYFN7vkCjXpyrEuKhc/BUO6wN/zVPAxq5ck=
 github.com/google/martian v2.1.0+incompatible h1:/CP5g8u/VJHijgedC/Legn3BAbAaWPgecwXBIDzw5no=
diff --git a/shared/appengine.go b/shared/appengine.go
@@ -20,7 +20,7 @@ import (
 	"cloud.google.com/go/datastore"
 	gclog "cloud.google.com/go/logging"
 	"github.com/gomodule/redigo/redis"
-	"github.com/google/go-github/v32/github"
+	"github.com/google/go-github/v33/github"
 	apps "google.golang.org/api/appengine/v1"
 	"google.golang.org/api/option"
 	mrpb "google.golang.org/genproto/googleapis/api/monitoredres"
diff --git a/shared/github_oauth.go b/shared/github_oauth.go
@@ -13,7 +13,7 @@ import (
 	"fmt"
 	"net/http"
 
-	"github.com/google/go-github/v32/github"
+	"github.com/google/go-github/v33/github"
 	"github.com/gorilla/securecookie"
 	"golang.org/x/oauth2"
 	ghOAuth "golang.org/x/oauth2/github"
diff --git a/shared/metadata_util.go b/shared/metadata_util.go
@@ -16,7 +16,7 @@ import (
 	"net/http"
 	"strings"
 
-	"github.com/google/go-github/v32/github"
+	"github.com/google/go-github/v33/github"
 )
 
 const sourceOwner string = "web-platform-tests"
diff --git a/shared/sharedtest/appengine_mock.go b/shared/sharedtest/appengine_mock.go
diff --git a/shared/sharedtest/github_oauth_mock.go b/shared/sharedtest/github_oauth_mock.go
diff --git a/shared/triage_metadata.go b/shared/triage_metadata.go
@@ -13,7 +13,7 @@ import (
 	"strconv"
 	"time"
 
-	"github.com/google/go-github/v32/github"
+	"github.com/google/go-github/v33/github"
 	"gopkg.in/yaml.v3"
 )
 
diff --git a/webapp/login_test.go b/webapp/login_test.go
@@ -13,7 +13,7 @@ import (
 	"strings"
 	"testing"
 
-	"github.com/google/go-github/v32/github"
+	"github.com/google/go-github/v33/github"
 	"github.com/gorilla/securecookie"
 	"github.com/stretchr/testify/assert"
 

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ import (`
`12`	`12`	`"net/url"`
`13`	`13`	`"time"`
`14`	`14`
`15`		`- "github.com/google/go-github/v32/github"`
	`15`	`+ "github.com/google/go-github/v33/github"`
`16`	`16`	`"github.com/web-platform-tests/wpt.fyi/api/checks/summaries"`
`17`	`17`	`"github.com/web-platform-tests/wpt.fyi/shared"`
`18`	`18`	`)`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ import (`
`17`	`17`	`"time"`
`18`	`18`
`19`	`19`	`jwt "github.com/dgrijalva/jwt-go"`
`20`		`- "github.com/google/go-github/v32/github"`
	`20`	`+ "github.com/google/go-github/v33/github"`
`21`	`21`	`"github.com/web-platform-tests/wpt.fyi/shared"`
`22`	`22`	`"golang.org/x/oauth2"`
`23`	`23`	`)`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ package summaries`
`9`	`9`	`import (`
`10`	`10`	`"testing"`
`11`	`11`
`12`		`- "github.com/google/go-github/v32/github"`
	`12`	`+ "github.com/google/go-github/v33/github"`
`13`	`13`	`"github.com/stretchr/testify/assert"`
`14`	`14`	`)`
`15`	`15`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ import (`
`16`	`16`	`mapset "github.com/deckarep/golang-set"`
`17`	`17`	`"github.com/gobuffalo/packr/v2"`
`18`	`18`
`19`		`- "github.com/google/go-github/v32/github"`
	`19`	`+ "github.com/google/go-github/v33/github"`
`20`	`20`	`"github.com/web-platform-tests/wpt.fyi/shared"`
`21`	`21`	`)`
`22`	`22`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`	`package summaries`
`6`	`6`
`7`	`7`	`import (`
`8`		`- "github.com/google/go-github/v32/github"`
	`8`	`+ "github.com/google/go-github/v33/github"`
`9`	`9`	`"github.com/web-platform-tests/wpt.fyi/shared"`
`10`	`10`	`)`
`11`	`11`