Skip to content

Commit 13ba7ce

Browse files
Drekabimoz-wptsync-bot
authored andcommitted
Relax target values to improve test performance on slower machines.
Differential Revision: https://phabricator.services.mozilla.com/D178698 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1834369 gecko-commit: b15de32be05d9c1ef2e783b468e6e0c3601217ff gecko-reviewers: jib
1 parent e59380d commit 13ba7ce

File tree

1 file changed

+14
-8
lines changed

1 file changed

+14
-8
lines changed

webrtc-extensions/RTCRtpReceiver-jitterBufferTarget-stats.html

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,14 @@
2525
"measure raising video jitterBufferTarget to 500");
2626
async_promise_test(t => applyJitterBufferTarget(t, "audio", 500),
2727
"measure raising audio jitterBufferTarget to 500");
28-
async_promise_test(t => applyJitterBufferTarget(t, "video", 250, 50),
29-
"measure lowering video jitterBufferTarget to 50");
30-
async_promise_test(t => applyJitterBufferTarget(t, "audio", 250, 50),
31-
"measure lowering audio jitterBufferTarget to 50");
32-
async_promise_test(t => applyJitterBufferTarget(t, "video", 500, 150),
28+
async_promise_test(t => applyJitterBufferTarget(t, "video", 250, 150),
3329
"measure lowering video jitterBufferTarget to 150");
34-
async_promise_test(t => applyJitterBufferTarget(t, "audio", 500, 150),
30+
async_promise_test(t => applyJitterBufferTarget(t, "audio", 250, 150),
3531
"measure lowering audio jitterBufferTarget to 150");
32+
async_promise_test(t => applyJitterBufferTarget(t, "video", 400, 250),
33+
"measure lowering video jitterBufferTarget to 300");
34+
async_promise_test(t => applyJitterBufferTarget(t, "audio", 400, 250),
35+
"measure lowering audio jitterBufferTarget to 300");
3636

3737
async function applyJitterBufferTarget(t, kind, target, targetToLower) {
3838
const caller = new RTCPeerConnection();
@@ -67,7 +67,8 @@
6767
async function measureDelayFromStats(t, receiver, callee, target, kind) {
6868
const lowerBound = target * 0.7;
6969
const upperBound = target * 1.3;
70-
let delay, oldInboundStats;
70+
let delay, oldInboundStats, prevDelay, rateOfChange;
71+
let numDelayMeasurements = 1;
7172

7273
for (let statChecks = 0; statChecks < 40; statChecks++) {
7374
await new Promise(r => t.step_timeout(r, 1000));
@@ -77,14 +78,19 @@
7778
if (oldInboundStats) {
7879
delay = ((inboundStats.jitterBufferDelay - oldInboundStats.jitterBufferDelay) /
7980
(inboundStats.jitterBufferEmittedCount - oldInboundStats.jitterBufferEmittedCount) * 1000);
81+
if (prevDelay) {
82+
rateOfChange = (delay - prevDelay) / numDelayMeasurements;
83+
numDelayMeasurements++;
84+
}
85+
prevDelay = delay;
8086
if (delay > lowerBound && delay < upperBound) {
8187
break;
8288
}
8389
}
8490
oldInboundStats = inboundStats;
8591
}
8692
t.step(() => assert_between_inclusive(delay , lowerBound, upperBound,
87-
`${kind} delay is within bounds`));
93+
`${kind} delay is within bounds rateOfChange ${rateOfChange} over ${numDelayMeasurements} measurements`));
8894
return delay;
8995
}
9096
</script>

0 commit comments

Comments
 (0)