Update QuotaExceededError expectations (#53645)

See whatwg/webidl#1465.

Author: domenic

WebCryptoAPI/getRandomValues.any.js

@@ -60,9 +60,9 @@ for (const array of arrays) {
 
     test(function() {
         const maxlength = 65536 / ctor.BYTES_PER_ELEMENT;
-        assert_throws_dom("QuotaExceededError", function() {
-            self.crypto.getRandomValues(new ctor(maxlength + 1))
-        }, "crypto.getRandomValues length over 65536")
+        assert_throws_quotaexceedederror(() => {
+            self.crypto.getRandomValues(new ctor(maxlength + 1));
+        }, null, null, "crypto.getRandomValues length over 65536");
     }, "Large length: " + array);
 
     test(function() {

ai/language_detection/detector.https.window.js

@@ -133,7 +133,7 @@ promise_test(async t => {
   const detectPromise = detector.detect(text);
 
   if (inputUsage >= detector.inputQuota) {
-    await promise_rejects_dom(t, 'QuotaExceededError', detectPromise);
+    await promise_rejects_quotaexceedederror(t, detectPromise, requested => requested !== null, detector.inputQuota);
   } else {
     await detectPromise;
   }

ai/translator/translator.optional.https.window.js

@@ -189,8 +189,7 @@ promise_test(async t => {
   if (inputUsage < translator.inputQuota) {
     assert_equals(await translator.translate(text), 'こんにちは');
   } else {
-    await promise_rejects_dom(
-        t, 'QuotaExceededError', translator.translate(text));
+    await promise_rejects_quotaexceedederror(t, translator.translate(text), requested => requested !== null, translator.inputQuota);
   }
 }, 'Translator.measureInputUsage() and inputQuota basic usage.');
 

background-fetch/fetch.https.window.js

@@ -170,10 +170,10 @@ backgroundFetchTest(async (test, backgroundFetch) => {
 
   // Very large download total that will definitely exceed the quota.
   const options = {downloadTotal: Number.MAX_SAFE_INTEGER};
-  await promise_rejects_dom(
-    test, 'QUOTA_EXCEEDED_ERR',
-    backgroundFetch.fetch(registrationId, 'resources/feature-name.txt', options),
-    'This fetch should have thrown a quota exceeded error');
+  await promise_rejects_quotaexceedederror(
+    test, backgroundFetch.fetch(registrationId, 'resources/feature-name.txt', options),
+    null, null
+  );
 
 }, 'Background Fetch that exceeds the quota throws a QuotaExceededError');
 

encrypted-media/scripts/setmediakeys-to-multiple-video-elements.js

@@ -35,7 +35,9 @@ function runTest(config, qualifier) {
             assert_equals(_video2.mediaKeys, _mediaKeys);
             return Promise.resolve();
         }, function(error) {
-            assert_equals(error.name, 'QuotaExceededError');
+            assert_equals(error.constructor, globalThis.QuotaExceededError, 'QuotaExceededError constructor match');
+            assert_equals(error.quota, null, 'quota');
+            assert_equals(error.requested, null, 'requested');
             assert_not_equals(error.message, '');
             // Return something so the promise resolves properly.
             return Promise.resolve();
@@ -51,4 +53,4 @@ function runTest(config, qualifier) {
             test.done();
         }).catch(onFailure);
     }, testname);
-}
+}

fetch/fetch-later/quota/accumulated-oversized-payload.tentative.https.window.js

@@ -37,15 +37,15 @@ test(
 
       // Makes the 2nd call (POST) to the same reporting origin that sends
       // max bytes, which should be rejected.
-      assert_throws_dom('QuotaExceededError', () => {
+      assert_throws_quotaexceedederror(() => {
         fetchLater(requestUrl, {
           method: 'POST',
           signal: controller.signal,
           body: makeBeaconData(generatePayload(quota), dataType),
           // Required, as the size of referrer also take up quota.
           referrer: '',
         });
-      });
+      }, null, null);
 
       // Makes the 3rd call (GET) to the same reporting origin, where its
       // request size is len(requestUrl) + headers, which should be accepted.

fetch/fetch-later/quota/max-payload.tentative.https.window.js

@@ -36,13 +36,14 @@ promise_test(async _ => {
 test(_ => {
   const uuid = token();
   const requestUrl = generateSetBeaconURL(uuid, {host: HTTPS_ORIGIN});
-  assert_throws_dom(
-      'QuotaExceededError',
-      () => fetchLater(requestUrl, {
-        activateAfter: 0,
-        method: 'POST',
-        body: generatePayload(
-            getRemainingQuota(QUOTA_PER_ORIGIN, requestUrl, headers) + 1,
-            dataType),
-      }));
+
+  assert_throws_quotaexceedederror(() => {
+    fetchLater(requestUrl, {
+          activateAfter: 0,
+          method: 'POST',
+          body: generatePayload(
+              getRemainingQuota(QUOTA_PER_ORIGIN, requestUrl, headers) + 1,
+              dataType),
+        });
+  }, null, null);
 }, `fetchLater() rejects max+1 payload in a POST request body of ${dataType}.`);

fetch/fetch-later/quota/oversized-payload.tentative.https.window.js

@@ -9,16 +9,16 @@ const OVERSIZED_REQUEST_BODY_SIZE = QUOTA_PER_ORIGIN + 1;
 for (const dataType in BeaconDataType) {
   // Test making a POST request with oversized payload, which should be rejected
   // by fetchLater API.
-  test(
-      () => assert_throws_dom(
-          'QuotaExceededError',
-          () => fetchLater('/', {
-            activateAfter: 0,
-            method: 'POST',
-            body: makeBeaconData(
-                generatePayload(OVERSIZED_REQUEST_BODY_SIZE), dataType),
-          })),
-      `fetchLater() does not accept payload[size=${
+  test(() => {
+    assert_throws_quotaexceedederror(() => {
+      fetchLater('/', {
+        activateAfter: 0,
+        method: 'POST',
+        body: makeBeaconData(
+            generatePayload(OVERSIZED_REQUEST_BODY_SIZE), dataType),
+      });
+    }, null, null);
+  }, `fetchLater() does not accept payload[size=${
           OVERSIZED_REQUEST_BODY_SIZE}] exceeding per-origin quota in a POST request body of ${
           dataType}.`);
 }

fetch/fetch-later/resources/fetch-later.html

@@ -30,12 +30,6 @@
       fetchLater(TARGET_URL, REQUEST_INIT);
       postMessageBack({type: FetchLaterIframeMessageType.DONE});
     } catch (e) {
-      if (e.name == "QuotaExceededError" &&
-          e instanceof DOMException) {
-        // PostMessage is unable to serialize the QuotExceededError object.
-        // Therefore do basic checks here and pass error name if successful.
-        e = {name: e.name};
-      }
       postMessageBack({type: FetchLaterIframeMessageType.ERROR, error: e});
     }
   </script>

fs/script-tests/FileSystemBaseHandle-buckets.js

@@ -34,10 +34,12 @@ directory_test(async (t, root_dir) => {
       await createFileWithContents('mtime.txt', 'short file', inboxRootDir);
 
   // Longer file fails.
-  return promise_rejects_dom(
-      t, 'QuotaExceededError',
-      createFileWithContents(
+  return promise_rejects_quotaexceedederror(
+    t,
+    createFileWithContents(
           'mtime2.txt',
           'Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum',
-          inboxRootDir));
+          inboxRootDir
+    ),
+    null, null);
 }, 'Bucket quota restricts the size of a file that can be created');