Skip to content

Commit 195dcf3

Browse files
palak8669chromium-wpt-export-bot
authored andcommitted
Don't expose page zoom in screenPixelRatio
This ensures it is updated with the spec defined in https://w3c.github.io/mediacapture-screen-share/#dfn-screenpixelratio. This CL also renames pixelRatio to screenPixelRatio as it is called in the spec. Bug: 396746625 Change-Id: I3ed1b0c3f2212d86207ce6167d227230781d7fcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6405674 Reviewed-by: Guido Urdaneta <[email protected]> Commit-Queue: Guido Urdaneta <[email protected]> Cr-Commit-Position: refs/heads/main@{#1439690}
1 parent cb1b816 commit 195dcf3

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

screen-capture/tentative/getdisplaymedia-captured-surface-resolution.https.html

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
assert_greater_than(settings.physicalHeight, 0);
4040
assert_equals(settings.physicalWidth / screenDetails.screens[0].devicePixelRatio, settings.logicalWidth);
4141
assert_equals(settings.physicalHeight / screenDetails.screens[0].devicePixelRatio, settings.logicalHeight);
42-
assert_equals(screenDetails.screens[0].devicePixelRatio, settings.pixelRatio);
42+
assert_equals(screenDetails.screens[0].devicePixelRatio, settings.screenPixelRatio);
4343
assert_equals(capabilities.width.max, settings.physicalWidth);
4444
assert_equals(capabilities.height.max, settings.physicalHeight);
4545
};
@@ -64,7 +64,7 @@
6464
assert_greater_than(settings.physicalHeight, 0);
6565
assert_equals(settings.physicalWidth / screenDetails.screens[0].devicePixelRatio, settings.logicalWidth);
6666
assert_equals(settings.physicalHeight / screenDetails.screens[0].devicePixelRatio, settings.logicalHeight);
67-
assert_equals(screenDetails.screens[0].devicePixelRatio, settings.pixelRatio);
67+
assert_equals(screenDetails.screens[0].devicePixelRatio, settings.screenPixelRatio);
6868
assert_equals(capabilities.width.max, settings.physicalWidth);
6969
assert_equals(capabilities.height.max, settings.physicalHeight);
7070
};
@@ -87,7 +87,7 @@
8787
assert_greater_than(settings.physicalHeight, 0);
8888
assert_equals(settings.physicalWidth / window.devicePixelRatio, settings.logicalWidth);
8989
assert_equals(settings.physicalHeight / window.devicePixelRatio, settings.logicalHeight);
90-
assert_equals(window.devicePixelRatio, settings.pixelRatio);
90+
assert_equals(window.devicePixelRatio, settings.screenPixelRatio);
9191
assert_equals(capabilities.width.max, settings.physicalWidth);
9292
assert_equals(capabilities.height.max, settings.physicalHeight);
9393
};
@@ -123,7 +123,7 @@
123123
assert_equals(oldPhysicalHeight, settings.physicalHeight);
124124
assert_equals(oldPhysicalWidth / screenDetails.screens[0].devicePixelRatio, settings.logicalWidth);
125125
assert_equals(oldPhysicalHeight / screenDetails.screens[0].devicePixelRatio, settings.logicalHeight);
126-
assert_equals(screenDetails.screens[0].devicePixelRatio, settings.pixelRatio);
126+
assert_equals(screenDetails.screens[0].devicePixelRatio, settings.screenPixelRatio);
127127
assert_equals(capabilities.width.max, settings.physicalWidth);
128128
assert_equals(capabilities.height.max, settings.physicalHeight);
129129
};
@@ -159,7 +159,7 @@
159159
assert_equals(oldPhysicalHeight, settings.physicalHeight);
160160
assert_equals(oldPhysicalWidth / screenDetails.screens[0].devicePixelRatio, settings.logicalWidth);
161161
assert_equals(oldPhysicalHeight / screenDetails.screens[0].devicePixelRatio, settings.logicalHeight);
162-
assert_equals(screenDetails.screens[0].devicePixelRatio, settings.pixelRatio);
162+
assert_equals(screenDetails.screens[0].devicePixelRatio, settings.screenPixelRatio);
163163
assert_equals(capabilities.width.max, settings.physicalWidth);
164164
assert_equals(capabilities.height.max, settings.physicalHeight);
165165
};
@@ -193,7 +193,7 @@
193193
assert_equals(oldPhysicalHeight, settings.physicalHeight);
194194
assert_equals(oldPhysicalWidth / window.devicePixelRatio, settings.logicalWidth);
195195
assert_equals(oldPhysicalHeight / window.devicePixelRatio, settings.logicalHeight);
196-
assert_equals(window.devicePixelRatio, settings.pixelRatio);
196+
assert_equals(window.devicePixelRatio, settings.screenPixelRatio);
197197
assert_equals(capabilities.width.max, settings.physicalWidth);
198198
assert_equals(capabilities.height.max, settings.physicalHeight);
199199
};

0 commit comments

Comments
 (0)