Skip to content

Commit 2dc6651

Browse files
mfreed7chromium-wpt-export-bot
authored andcommitted
Remove stashed request headers for speculative parser tests
The old code would append all of the request headers for the request to the stashed value. That causes the failure string for all dependent tests to change when, e.g. the User-Agent string changes due to the test being run on a different bot. This CL removes the headers, as those seem only useful for debugging, and are causing lots of flaky behavior on at least Chromium bots. Prior failure message: FAIL Speculative parsing, document.write(): link-rel-stylesheet-disabled Unhandled rejection: assert_equals: speculative case incorrectly fetched expected "" but got "param-encodingcheck: %C4%9E\r\nHost: web-platform.test:8001\nConnection: keep-alive\nUser-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/999.77.34.5 Safari/537.36\nAccept: text/css,*/*;q=0.1\nReferer: http://web-platform.test:8001/html/syntax/speculative-parsing/generated/document-write/link-rel-stylesheet-disabled.tentative.sub.html\nAccept-Encoding: gzip, deflate\nAccept-Language: en-us,en\n\n" New failure message: FAIL Speculative parsing, document.write(): link-rel-stylesheet-disabled Unhandled rejection: assert_equals: speculative case incorrectly fetched expected "" but got "param-encodingcheck: %C4%9E\r\n" Fixed: 1250457,1249920,1249921,1249954,1250003,1250004 Bug: 1144176 Change-Id: I45dbbb8794c6bf2d5e962cecf531e06a7af09160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3170927 Commit-Queue: Mason Freed <[email protected]> Auto-Submit: Mason Freed <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#923491}
1 parent 30e724a commit 2dc6651

File tree

1 file changed

+1
-1
lines changed
  • html/syntax/speculative-parsing/resources

1 file changed

+1
-1
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
def main(request, response):
22
if request.GET[b"action"] == b"put":
33
encodingcheck = u"param-encodingcheck: " + request.url_parts.query.split(u"&encodingcheck=")[1] + u"\r\n"
4-
request.server.stash.put(request.GET[b"uuid"], encodingcheck + str(request.raw_headers))
4+
request.server.stash.put(request.GET[b"uuid"], encodingcheck)
55
return u''
66
return request.server.stash.take(request.GET[b"uuid"])

0 commit comments

Comments
 (0)