Skip to content

Commit 502445e

Browse files
[credentialless] Use SameSite=None in WPT. (#30359)
SameSite=None is the laxest option for cookies. This change ensures omitting credentials is caused by COEP:credentialless and not because of the cookie policy. Bug: 1175099 Change-Id: I4ae4a4a4389d1d958fa54aef55e8070c07b1be57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3141445 Commit-Queue: Arthur Sonzogni <[email protected]> Reviewed-by: Antonio Sartori <[email protected]> Cr-Commit-Position: refs/heads/main@{#918610} Co-authored-by: Arthur Sonzogni <[email protected]>
1 parent b3958a2 commit 502445e

12 files changed

+43
-21
lines changed

html/cross-origin-embedder-policy/credentialless/cache.tentative.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
`?uuid=${request_token}`;
5454

5555
promise_setup(async test => {
56-
await setCookie(cross_origin, cookie_key, cookie_value);
56+
await setCookie(cross_origin, cookie_key, cookie_value + cookie_same_site_none);
5757
}, "Set cookie");
5858

5959
// The "same-origin" COEP:unsafe-none document fetchs a "cross-origin"

html/cross-origin-embedder-policy/credentialless/dedicated-worker.tentative.https.html

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,10 @@
1717
promise_test(async test => {
1818

1919
await Promise.all([
20-
setCookie(same_origin, cookie_key, cookie_same_origin),
21-
setCookie(cross_origin, cookie_key, cookie_cross_origin),
20+
setCookie(same_origin, cookie_key, cookie_same_origin +
21+
cookie_same_site_none),
22+
setCookie(cross_origin, cookie_key, cookie_cross_origin +
23+
cookie_same_site_none),
2224
]);
2325

2426
// One window with COEP:none. (control)

html/cross-origin-embedder-policy/credentialless/fetch.tentative.https.html

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,10 @@
1414
const cookie_cross_origin = "cross_origin";
1515

1616
await Promise.all([
17-
setCookie(same_origin, cookie_key, cookie_same_origin),
18-
setCookie(cross_origin, cookie_key, cookie_cross_origin),
17+
setCookie(same_origin, cookie_key, cookie_same_origin +
18+
cookie_same_site_none),
19+
setCookie(cross_origin, cookie_key, cookie_cross_origin +
20+
cookie_same_site_none),
1921
]);
2022

2123
// One window with COEP:none. (control)

html/cross-origin-embedder-policy/credentialless/iframe.tentative.html

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,10 @@
4040

4141
promise_test_parallel(async test => {
4242
await Promise.all([
43-
setCookie(same_origin, cookie_key, cookie_same_origin),
44-
setCookie(cross_origin, cookie_key, cookie_cross_origin),
43+
setCookie(same_origin, cookie_key, cookie_same_origin +
44+
cookie_same_site_none),
45+
setCookie(cross_origin, cookie_key, cookie_cross_origin +
46+
cookie_same_site_none),
4547
]);
4648

4749
iframeTest("same-origin", same_origin, cookie_same_origin);

html/cross-origin-embedder-policy/credentialless/image.tentative.https.html

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,10 @@
1515
const cookie_cross_origin = "cross_origin";
1616

1717
await Promise.all([
18-
setCookie(same_origin, cookie_key, cookie_same_origin),
19-
setCookie(cross_origin, cookie_key, cookie_cross_origin),
18+
setCookie(same_origin, cookie_key, cookie_same_origin +
19+
cookie_same_site_none),
20+
setCookie(cross_origin, cookie_key, cookie_cross_origin +
21+
cookie_same_site_none),
2022
]);
2123

2224
// One window with COEP:none. (control)

html/cross-origin-embedder-policy/credentialless/link.tentative.https.html

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,10 @@
1515
const cookie_cross_origin = "cross_origin";
1616

1717
await Promise.all([
18-
setCookie(same_origin, cookie_key, cookie_same_origin),
19-
setCookie(cross_origin, cookie_key, cookie_cross_origin),
18+
setCookie(same_origin, cookie_key, cookie_same_origin +
19+
cookie_same_site_none),
20+
setCookie(cross_origin, cookie_key, cookie_cross_origin +
21+
cookie_same_site_none),
2022
]);
2123

2224
// One window with COEP:none. (control)

html/cross-origin-embedder-policy/credentialless/redirect.tentative.html

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,10 @@
4242

4343
promise_test_parallel(async test => {
4444
await Promise.all([
45-
setCookie(same_origin, cookie_key, cookie_same_origin),
46-
setCookie(cross_origin, cookie_key, cookie_cross_origin),
45+
setCookie(same_origin, cookie_key, cookie_same_origin +
46+
cookie_same_site_none),
47+
setCookie(cross_origin, cookie_key, cookie_cross_origin +
48+
cookie_same_site_none),
4749
]);
4850

4951
redirectTest("same-origin -> same-origin",

html/cross-origin-embedder-policy/credentialless/resources/common.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ const coop_same_origin =
2323
const corp_cross_origin =
2424
'|header(Cross-Origin-Resource-Policy,cross-origin)';
2525

26+
const cookie_same_site_none = ';SameSite=None;Secure';
27+
2628
// Test using the modern async/await primitives are easier to read/write.
2729
// However they run sequentially, contrary to async_test. This is the parallel
2830
// version, to avoid timing out.

html/cross-origin-embedder-policy/credentialless/script.tentative.https.html

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,10 @@
1515
const cookie_cross_origin = "cross_origin";
1616

1717
await Promise.all([
18-
setCookie(same_origin, cookie_key, cookie_same_origin),
19-
setCookie(cross_origin, cookie_key, cookie_cross_origin),
18+
setCookie(same_origin, cookie_key, cookie_same_origin +
19+
cookie_same_site_none),
20+
setCookie(cross_origin, cookie_key, cookie_cross_origin +
21+
cookie_same_site_none),
2022
]);
2123

2224
// One window with COEP:none. (control)

html/cross-origin-embedder-policy/credentialless/service-worker.tentative.https.html

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,10 @@
1717

1818
promise_test(async t => {
1919
await Promise.all([
20-
setCookie(same_origin, cookie_key, cookie_same_origin),
21-
setCookie(cross_origin, cookie_key, cookie_cross_origin),
20+
setCookie(same_origin, cookie_key, cookie_same_origin +
21+
cookie_same_site_none),
22+
setCookie(cross_origin, cookie_key, cookie_cross_origin +
23+
cookie_same_site_none),
2224
]);
2325

2426
// One iframe with COEP:none. (control)

0 commit comments

Comments
 (0)