Skip to content

Commit 648c9e3

Browse files
[view-transitions] Fix incomplete pausing of animations in reftests.
The 50s duration on pseudo-renderiong-invalidation still permitted drift in pixel values, presumably due to cross-fade brightening. Replaced with a pause. The other tests were pausing on the group, but animation-play-state is non-inheritted so animation in the image-pair, old, and new were still running. These are all paused now. Bug: 324915834, 343288729 Change-Id: I56b9f13e41121787faef21e19d204399f8a2bc2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6409153 Reviewed-by: Vladimir Levin <[email protected]> Commit-Queue: Kevin Ellis <[email protected]> Cr-Commit-Position: refs/heads/main@{#1439621}
1 parent 614013a commit 648c9e3

File tree

3 files changed

+13
-4
lines changed

3 files changed

+13
-4
lines changed

css/css-view-transitions/active-view-transition-on-non-root.html

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,10 @@
2121
background: red;
2222
}
2323

24-
::view-transition-group(*) {
24+
::view-transition-group(*),
25+
::view-transition-image-pair(*),
26+
::view-transition-old(*),
27+
::view-transition-new(*) {
2528
animation-play-state: paused;
2629
}
2730
</style>

css/css-view-transitions/active-view-transition-type-on-non-root.html

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,10 @@
2121
background: red;
2222
}
2323

24-
::view-transition-group(*) {
24+
::view-transition-group(*),
25+
::view-transition-image-pair(*),
26+
::view-transition-old(*),
27+
::view-transition-new(*) {
2528
animation-play-state: paused;
2629
}
2730
</style>

css/css-view-transitions/pseudo-rendering-invalidation.html

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,11 @@
2828
background: darkseagreen;
2929
}
3030

31-
::view-transition-group(*) {
32-
animation-duration: 50s;
31+
::view-transition-group(*),
32+
::view-transition-image-pair(*),
33+
::view-transition-old(*),
34+
::view-transition-new(*) {
35+
animation-play-state: paused;
3336
}
3437

3538
::view-transition {

0 commit comments

Comments
 (0)