Mark for whitespace reattachment based on layout object parent

lilles · chromium-wpt-export-bot · commit 891bc0249bb3 · 2021-09-23T05:07:43.000-07:00
The existing code marked based on light tree parent, which did not work correctly for slotted elements. Instead keep track of the last layout object parent which got a child removed during the detach part of a DOM or flat tree removal. The marking is only done for the closest LayoutObject parent of the detached subtree. If the marking was done for every LayoutObject removal in the subtree, the style recalc root would not be updated correctly and we would have a less optimal recalc root as we try to update the recalc root after the removal is complete. Fixes two correctness issues and prepares for using the same framework for doing the same for list item updates. Bug: 1244080, 1247079, 1239137 Change-Id: Iacfe010c50f3f33a5e45b3ea996a3f42cb465f84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3172622 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#924258}
diff --git a/css/css-text/white-space/display-contents-remove-whitespace-change.html b/css/css-text/white-space/display-contents-remove-whitespace-change.html
@@ -0,0 +1,12 @@
+<!doctype html>
+<meta charset="utf-8">
+<title>Remove display:contents with block child and whitespace sibling</title>
+<link rel="help" href="https://drafts.csswg.org/css-display-3/#valdef-display-contents">
+<link rel="help" href="https://drafts.csswg.org/css-text-3/#white-space-rules">
+<link rel="match" href="../../reference/pass_if_two_words.html">
+<p>There should be a space between "two" and "words" below.</p>
+two<div id="rm" style="display:contents"><div></div></div> <span>words</span>
+<script>
+  rm.offsetTop;
+  rm.remove();
+</script>
diff --git a/css/css-text/white-space/remove-slotted-with-whitespace-sibling.html b/css/css-text/white-space/remove-slotted-with-whitespace-sibling.html
@@ -0,0 +1,11 @@
+<!doctype html>
+<link rel="help" href="https://drafts.csswg.org/css-text-3/#white-space-rules">
+<link rel="match" href="../../reference/pass_if_two_words.html">
+<p>There should be a space between "two" and "words" below.</p>
+<div id="host">two<div id="rm"></div> <span>words</span></div>
+<script>
+  let root = host.attachShadow({mode:"open"});
+  root.innerHTML = "<slot></slot>";
+  host.offsetTop;
+  rm.slot = "unknown";
+</script>
