Skip to content

Commit 93b6866

Browse files
irorichromium-wpt-export-bot
authored andcommitted
Improve error messages of generate-test-{sxgs,wbns}.sh
`go get` installs commands in $GOPATH/bin (or ~/go/bin if $GOPATH is not set), which may not be listed in the user's PATH environment variable. crrev.com/c/2556739 updated third_party/blink/web_tests/http/tests/ loading/sxg/resources/generate-test-sxgs.sh, and this updates the remaining scripts and READMEs. Bug: 1151384 Change-Id: I2719fad30d3bb1141fb7abbecb8a2cf1b638a51d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557159 Reviewed-by: Hayato Ito <[email protected]> Commit-Queue: Kunihiko Sakamoto <[email protected]> Cr-Commit-Position: refs/heads/master@{#830883}
1 parent 03f5a82 commit 93b6866

File tree

4 files changed

+4
-0
lines changed

4 files changed

+4
-0
lines changed

signed-exchange/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,5 @@ regenerate these files by running `generate-test-sxgs.sh` in the
1919
To install them, run:
2020
```
2121
go get -u github.com/WICG/webpackage/go/signedexchange/cmd/...
22+
export PATH=$PATH:$(go env GOPATH)/bin
2223
```

signed-exchange/resources/generate-test-sxgs.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ for cmd in gen-signedexchange gen-certurl dump-signedexchange; do
1919
if ! command -v $cmd > /dev/null 2>&1; then
2020
echo "$cmd is not installed. Please run:"
2121
echo " go get -u github.com/WICG/webpackage/go/signedexchange/cmd/..."
22+
echo ' export PATH=$PATH:$(go env GOPATH)/bin'
2223
exit 1
2324
fi
2425
done

web-bundle/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,5 @@ This directory contains tests for the
66
To install them, run:
77
```
88
go get -u github.com/WICG/webpackage/go/bundle/cmd/...
9+
export PATH=$PATH:$(go env GOPATH)/bin
910
```

web-bundle/resources/generate-test-wbns.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ set -e
55
if ! command -v gen-bundle > /dev/null 2>&1; then
66
echo "gen-bundle is not installed. Please run:"
77
echo " go get -u github.com/WICG/webpackage/go/bundle/cmd/..."
8+
echo ' export PATH=$PATH:$(go env GOPATH)/bin'
89
exit 1
910
fi
1011

0 commit comments

Comments
 (0)