Skip to content

Commit a591743

Browse files
shivamidowchromium-wpt-export-bot
authored andcommitted
Apply a fallback for font-size-adjust: ic-height when a required font metric is missing.
The W3C CSS WG resolved font-size-adjust with missing metrics by applying the same way we do for other missing typographical units [1]. This CL aims to align with the resolution. [1] w3c/csswg-drafts#6384 (comment) Bug: 346773386, 325981757 Change-Id: I9dadf89c7e95b249ae149df7d15ccc0f55ea760a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5637274 Reviewed-by: Dominik Röttsches <[email protected]> Commit-Queue: ChangSeok Oh <[email protected]> Cr-Commit-Position: refs/heads/main@{#1317246}
1 parent f776985 commit a591743

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

css/css-fonts/font-size-adjust-ic-height-ref.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@
1818
font-family: NotoSansCJK;
1919
font-size: 200px;
2020
}
21-
.notAdjustedRef {
21+
.fallbackRef {
2222
font-family: Ahem;
23-
font-size: 100px;
23+
font-size: 50px;
2424
}
2525
</style>
2626
<div class="adjustedRef"></div>
27-
<div class="notAdjustedRef"></div>
27+
<div class="fallbackRef"></div>

css/css-fonts/font-size-adjust-ic-height.tentative.html renamed to css/css-fonts/font-size-adjust-ic-height.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,11 @@
2626
Therefore, an ic-height 2.0 means a 200% scaling up. */
2727
font-size-adjust: ic-height 2.0;
2828
}
29-
.notAdjusted {
29+
.fallback {
3030
font-family: Ahem;
31-
/* The Ahem font lacks vertical metrics, so no adjustment is applied. */
31+
/* The Ahem font lacks vertical metrics, so a fallback is applied. */
3232
font-size-adjust: ic-height 0.5;
3333
}
3434
</style>
3535
<div class="adjusted"></div>
36-
<div class="notAdjusted"></div>
36+
<div class="fallback"></div>

0 commit comments

Comments
 (0)