Commit aafdb1d
Remove nonstandard block-axis 1px margins from textarea default styles.
These 1px margins were added (with no explanation/bug-link) in 1999, here:
https://searchfox.org/firefox-main/diff/784c6428b65d9539cc8f5e30d18e59a050740007/layout/html/document/src/html.css#1293
They're not part of the html spec, and Chromium/WebKit don't have them; and at
least one web developer has run up against them as a sharp edge (causing a
textarea with 'height:100vh' to unexpectedly overflow the viewport).
So, let's just remove them.
As part of this change, we can also simplify the reference cases for reftest
ua-style-sheet-textarea-1.html - it had two reference cases which had two
different ways to confirm that we properly interpret these logical block-axis
margins. Now that the margins are gone, there's no point in having two
different reference cases (they end up ~identical once their margin
declarations are removed), so this patch merges the reference cases into a
single one with no need to specify margins.
Differential Revision: https://phabricator.services.mozilla.com/D286187
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1875156
gecko-commit: 5545120859d3f38c45a1109125481c8fbe84224d
gecko-reviewers: layout-reviewers, firefox-style-system-reviewers, emilio1 parent 07d9718 commit aafdb1d
File tree
1 file changed
+22
-0
lines changed- html/rendering/replaced-elements/the-textarea-element
1 file changed
+22
-0
lines changedLines changed: 22 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
0 commit comments