Skip to content

Commit b84fcfe

Browse files
AlaskanEmilymoz-wptsync-bot
authored andcommitted
Part 1 - Do not allow grid flex tracks to grow during intrinsic sizing of the grid container itself
Add a test which is specifically failed before this patch (with the pref enabled) but is fixed by the patch. This specific case seems to not be tested in isolation by WPT. This fixes the major issue we found with bug 1938619, and enables the pref layout.css.grid-flex-spanning-items-intrinsic-sizing.enabled in nightly-only. Differential Revision: https://phabricator.services.mozilla.com/D243030 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1955109 gecko-commit: dcacdafdb21522474b108b621ea3b27abe7a1d2b gecko-reviewers: layout-grid-reviewers, dholbert
1 parent 1e0f0d8 commit b84fcfe

File tree

2 files changed

+46
-0
lines changed

2 files changed

+46
-0
lines changed
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
<!DOCTYPE html>
2+
<meta charset="utf-8">
3+
<title>CSS Grid Layout Reference Case</title>
4+
<link rel="author" title="Emily McDonough" href="mailto:[email protected]"/>
5+
<style>
6+
#holder {
7+
height: 50px;
8+
width: 30px;
9+
border: 10px solid fuchsia;
10+
}
11+
#item {
12+
width: 300px;
13+
height: 50px;
14+
background: aqua;
15+
}
16+
</style>
17+
<div id="holder">
18+
<div id="item"></div>
19+
</div>
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
<!DOCTYPE html>
2+
<meta charset="utf-8">
3+
<title>CSS Grid Layout Test: Intrinsic sizing of grid with spanning flex items in a min-content container</title>
4+
<link rel="match" href="grid-flex-spanning-items-001-ref.html"/>
5+
<link rel="help" href="https://drafts.csswg.org/css-grid-2/#intrinsic-sizes"/>
6+
<link rel="author" title="Emily McDonough" href="mailto:[email protected]"/>
7+
<style>
8+
#mygrid {
9+
display: grid;
10+
grid-template-columns: 1fr 30px;
11+
border: 10px solid fuchsia;
12+
width: min-content;
13+
}
14+
#item {
15+
grid-column: 1 / span 2;
16+
}
17+
#filler {
18+
width: 300px;
19+
height: 50px;
20+
background: aqua;
21+
}
22+
</style>
23+
<div id="mygrid">
24+
<div id="item">
25+
<div id="filler"></div>
26+
</div>
27+
</div>

0 commit comments

Comments
 (0)