LanguageDetector: Remove AILanguageDetectorFactory

christine-hollingsworth · chromium-wpt-export-bot · commit bdabc4fb1c23 · 2025-03-27T14:47:05.000-07:00
Remove AILanguageDetectorFactory and expose create and availability statically on LanguageDetector. This is a followup change to CLs crrev.com/c/6402873, crrev.com/c/6402775. Note: This change is a cherry-pick of crrev.com/c/6397965. Some changes have been made as part of rebasing + fixing previous CQ test failures. PS #1 represents the cherry-picked change prior to rebase + minor edits. Fixed: 402165734 Change-Id: Id384ebe31ccfe9e0efd65dd7c890cd66875a9ed8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6403274 Reviewed-by: Mike Wasserman <msw@chromium.org> Commit-Queue: Christine Hollingsworth <christinesm@chromium.org> Cr-Commit-Position: refs/heads/main@{#1439000}
diff --git a/ai/language_detection/availability-detached-crash.tentative.https.html b/ai/language_detection/availability-detached-crash.tentative.https.html
@@ -5,7 +5,7 @@
 <body>
 <iframe src="about:blank"></iframe>
 <script>
-const factory = frames[0].ai.languageDetector;
+const factory = frames[0].LanguageDetector;
 const detector = factory.create();
 document.getElementsByTagName("iframe")[0].remove();
 detector.availability();
diff --git a/ai/language_detection/detector.https.tentative.any.js b/ai/language_detection/detector.https.tentative.any.js
@@ -6,13 +6,13 @@
 
 promise_test(async t => {
   // Language detection is available after call to `create()`.
-  await ai.languageDetector.create();
-  const availability = await ai.languageDetector.availability();
+  await LanguageDetector.create();
+  const availability = await LanguageDetector.availability();
   assert_equals(availability, 'available');
 }, 'Simple LanguageDetector.availability() call');
 
 promise_test(async t => {
-  const detector = await ai.languageDetector.create();
+  const detector = await LanguageDetector.create();
   const results = await detector.detect('this string is in English');
   // "en" should be highest confidence.
   assert_equals(results[0].detectedLanguage, 'en');
@@ -26,37 +26,37 @@ promise_test(async t => {
   const controller = new AbortController();
   controller.abort();
 
-  const createPromise = ai.languageDetector.create({signal: controller.signal});
+  const createPromise = LanguageDetector.create({signal: controller.signal});
 
   await promise_rejects_dom(t, 'AbortError', createPromise);
-}, 'AILanguageDetectorFactory.create() call with an aborted signal.');
+}, 'LanguageDetector.create() call with an aborted signal.');
 
 promise_test(async t => {
   await testAbortPromise(t, signal => {
-    return ai.languageDetector.create({signal});
+    return LanguageDetector.create({signal});
   });
-}, 'Aborting AILanguageDetectorFactory.create().');
+}, 'Aborting LanguageDetector.create().');
 
 promise_test(async t => {
   const controller = new AbortController();
   controller.abort();
 
-  const detector = await ai.languageDetector.create();
+  const detector = await LanguageDetector.create();
   const detectPromise =
       detector.detect('this string is in English', {signal: controller.signal});
 
   await promise_rejects_dom(t, 'AbortError', detectPromise);
 }, 'LanguageDetector.detect() call with an aborted signal.');
 
 promise_test(async t => {
-  const detector = await ai.languageDetector.create();
+  const detector = await LanguageDetector.create();
   await testAbortPromise(t, signal => {
     return detector.detect('this string is in English', {signal});
   });
 }, 'Aborting LanguageDetector.detect().');
 
 promise_test(async t => {
-  const detector = await ai.languageDetector.create();
+  const detector = await LanguageDetector.create();
 
   const text = 'this string is in English';
   const inputUsage = await detector.measureInputUsage(text);
@@ -77,15 +77,15 @@ promise_test(async t => {
   const controller = new AbortController();
   controller.abort();
 
-  const detector = await ai.languageDetector.create();
+  const detector = await LanguageDetector.create();
   const measureInputUsagePromise =
       detector.measureInputUsage('hello', {signal: controller.signal});
 
   await promise_rejects_dom(t, 'AbortError', measureInputUsagePromise);
 }, 'Translator.measureInputUsage() call with an aborted signal.');
 
 promise_test(async t => {
-  const detector = await ai.languageDetector.create();
+  const detector = await LanguageDetector.create();
   await testAbortPromise(t, signal => {
     return detector.measureInputUsage('hello', {signal});
   });
