Skip to content

Commit d2237d4

Browse files
Stop making appearance:base-select submit form on enter
When customizable select was going to be a new element, we decided on the enter form submission behavior here: openui/open-ui#386 It got negative feedback in the attached bug since customizable select now reuses the select element, so this patch reverts the behavior and makes it do the same thing as appearance:auto select. Fixed: 429647164 Change-Id: Ia40a309270d8f34123c5f697f583ae982eebd24d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6959790 Commit-Queue: Joey Arhar <[email protected]> Reviewed-by: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1520122}
1 parent 9ab8d78 commit d2237d4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

html/semantics/forms/the-select-element/customizable-select/select-keyboard-behavior.optional.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@
140140
}, {once: true});
141141
await test_driver.send_keys(select, Enter);
142142
await new Promise(requestAnimationFrame);
143-
assert_true(formWasSubmitted,
143+
assert_false(formWasSubmitted,
144144
'Enter should submit the form when the listbox is closed.');
145145
assert_false(select.matches(':open'),
146146
'Enter should not open the listbox when it is in a form.');

0 commit comments

Comments
 (0)