Commit d5e6a87
Ability to check inline/float/OOF without LayoutObject bits.
As pointed out in LayoutBox::IsValidColumnSpanner(), this function may
be called at "inconvenient" times, also before StyleDidChange() has
finished, so we cannot trust the LayoutObject bits for inline-level,
float, or position. Add the ability to provide this information without
checking those bits. The information we need is computed style and
layout object type.
It was possible for the function to return true for `column-span:all`
and `float:left`, which is wrong.
Bug: 417256483
Change-Id: Iaa8903a716a5f9a1d4cc18d42c48680e7fb2c551
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6540050
Commit-Queue: Morten Stenshorne <[email protected]>
Reviewed-by: Ian Kilpatrick <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1459638}1 parent d6d1aff commit d5e6a87
1 file changed
+11
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
0 commit comments