Skip to content

Commit d5e6a87

Browse files
mstenshochromium-wpt-export-bot
authored andcommitted
Ability to check inline/float/OOF without LayoutObject bits.
As pointed out in LayoutBox::IsValidColumnSpanner(), this function may be called at "inconvenient" times, also before StyleDidChange() has finished, so we cannot trust the LayoutObject bits for inline-level, float, or position. Add the ability to provide this information without checking those bits. The information we need is computed style and layout object type. It was possible for the function to return true for `column-span:all` and `float:left`, which is wrong. Bug: 417256483 Change-Id: Iaa8903a716a5f9a1d4cc18d42c48680e7fb2c551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6540050 Commit-Queue: Morten Stenshorne <[email protected]> Reviewed-by: Ian Kilpatrick <[email protected]> Cr-Commit-Position: refs/heads/main@{#1459638}
1 parent d6d1aff commit d5e6a87

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
<!DOCTYPE html>
2+
<link rel="author" title="Morten Stenshorne" href="mailto:[email protected]">
3+
<link rel="help" href="https://issues.chromium.org/issues/417256483">
4+
<div style="columns:2;">
5+
<div id="e59" style="float:left; width:100px; column-span:all;"></div>
6+
m
7+
</div>
8+
<script>
9+
document.body.offsetTop;
10+
e59.style.width = "101px";
11+
</script>

0 commit comments

Comments
 (0)