Fix the popover-attribute-basic.tentative.html test

This test has been disabled for some time, while [1] was landed. Then
[2] landed, which changed the event names/behavior, but that CL forgot
to update this test. Additionally, there was a crash that was fixed
in [3]. This CL cleans it up and re-enables it finally.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/4074305
[2] https://chromium-review.googlesource.com/c/chromium/src/+/4035832
[3] https://chromium-review.googlesource.com/c/chromium/src/+/4074665

Bug: 1307772
Change-Id: I3f0b9fb604a04cb0cc28370f40d8b02d5fce11ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4090644
Commit-Queue: Mason Freed <[email protected]>
Auto-Submit: Mason Freed <[email protected]>
Reviewed-by: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1081664}

Author: mfreed7

html/semantics/popovers/popover-attribute-basic.tentative.html

@@ -275,16 +275,17 @@
     other_popover.showPopover();
     const popover = createPopover(t);
     popover.setAttribute('popover','auto');
-    other_popover.addEventListener('toggle', (e) => {
-      if (e.state !== "closing") return;
+    other_popover.addEventListener('beforetoggle', (e) => {
+      if (e.newState !== "closed")
+        return;
       popover.setAttribute('popover','manual');
     },{once: true});
     assert_true(other_popover.matches(':open'));
     assert_false(popover.matches(':open'));
     popover.showPopover();
     assert_false(other_popover.matches(':open'),'unrelated popover is hidden');
     assert_false(popover.matches(':open'),'popover is not shown if its type changed during show');
-  },`Changing the popover type in a "toggle" event handler should not cause problems (during showPopover())`);
+  },`Changing the popover type in a "beforetoggle" event handler should not cause problems (during showPopover())`);
 
   test((t) => {
     const popover = createPopover(t);
@@ -295,13 +296,15 @@
     popover.showPopover();
     other_popover.showPopover();
     let nested_popover_hidden=false;
-    other_popover.addEventListener('toggle', (e) => {
-      if (e.state !== "closing") return;
+    other_popover.addEventListener('beforetoggle', (e) => {
+      if (e.newState !== "closed")
+        return;
       nested_popover_hidden = true;
       popover.setAttribute('popover','manual');
     },{once: true});
-    popover.addEventListener('toggle', (e) => {
-      if (e.state !== "closing") return;
+    popover.addEventListener('beforetoggle', (e) => {
+      if (e.newState !== "closed")
+        return;
       assert_true(nested_popover_hidden,'The nested popover should be hidden first');
     },{once: true});
     assert_true(popover.matches(':open'));
@@ -310,7 +313,7 @@
     assert_false(other_popover.matches(':open'),'unrelated popover is hidden');
     assert_false(popover.matches(':open'),'popover is still hidden if its type changed during hide event');
     assert_throws_dom("InvalidStateError",() => other_popover.hidePopover(),'Nested popover should already be hidden');
-  },`Changing the popover type in a "toggle" event handler should not cause problems (during hidePopover())`);
+  },`Changing the popover type in a "beforetoggle" event handler should not cause problems (during hidePopover())`);
 
   function interpretedType(typeString,method) {
     if (validTypes.includes(typeString))
@@ -347,8 +350,9 @@
             popover.showPopover();
             assert_true(popover.matches(':open'));
             let gotEvent = false;
-            popover.addEventListener('toggle', (e) => {
-              if (e.state !== "closing") return;
+            popover.addEventListener('beforetoggle', (e) => {
+              if (e.newState !== "closed")
+                return;
               gotEvent = true;
               setPopoverValue(popover,inEventType,method);
             },{once:true});
@@ -384,7 +388,7 @@
                 }
               }
             }
-          },`Changing a popover from ${type} to ${newType} (via ${method}), and then ${inEventType} during 'toggle' works`);
+          },`Changing a popover from ${type} to ${newType} (via ${method}), and then ${inEventType} during 'beforetoggle' works`);
         });
       });
     });