Skip to content

Commit e427710

Browse files
utpathakchromium-wpt-export-bot
authored andcommitted
Fix failing WPTs introduced by https://crrev.com/c/5937916
There are few failures introduced by WPT import in the editing component where the editing includes insertHTML command alongwith the white-space CSS properties. This CL fixes the failing WPTs by setting the expectation as per the CSS specification linked below. This change only updates the expectation for the failing WPTs which were introduced by this[1] CL and seem to have wrong expectations. [1] https://crrev.com/c/5937916 [2] https://www.w3.org/TR/css-text-3/#white-space-property Bug: 373924023 Change-Id: I31f2e63275e986c37cc423c5b0c878296d8ee5a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5960541 Reviewed-by: Siye Liu <[email protected]> Reviewed-by: Kent Tamura <[email protected]> Commit-Queue: Utkarsh Pathak <[email protected]> Cr-Commit-Position: refs/heads/main@{#1391524}
1 parent 0b9fc07 commit e427710

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

editing/data/inserthtml.js

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -487,7 +487,7 @@ var browserTests = [
487487
{"inserthtml":[false,false,"",false,false,""]}],
488488
["<p>{}<br></p>",
489489
[["inserthtml","<!--abc-->"]],
490-
"<p><!--abc-->{}<br></p>",
490+
"<p><!--abc-->{}</p>",
491491
[true],
492492
{"inserthtml":[false,false,"",false,false,""]}],
493493
["<p><!--foo-->{}<span><br></span><!--bar--></p>",
@@ -521,7 +521,7 @@ var browserTests = [
521521
{"inserthtml":[false,false,"",false,false,""]}],
522522
["<p><br>{}</p>",
523523
[["inserthtml","<!--abc-->"]],
524-
"<p><!--abc--><br></p>",
524+
"<p><!--abc--></p>",
525525
[true],
526526
{"inserthtml":[false,false,"",false,false,""]}],
527527
["<p><!--foo--><span><br></span>{}<!--bar--></p>",
@@ -567,19 +567,21 @@ var browserTests = [
567567
{"inserthtml":[false,false,"",false,false,""]}],
568568
["<pre contenteditable=\"false\"><span contenteditable>[1234]</span></pre>",
569569
[["inserthtml","<pre>abc</pre>"]],
570-
"<pre contenteditable=\"false\"><span contenteditable=\"\">abc</span></pre>",
570+
["<pre contenteditable=\"false\"><span contenteditable=\"\">abc</span></pre>",
571+
"<pre contenteditable=\"false\"><span contenteditable=\"\">abc</span></pre>"],
571572
[true],
572573
{"inserthtml":[false,false,"",false,false,""]}],
573574

574575
// Empty inline elements shouldn't be deleted if they are inserted intentionally
575576
["<div>a[]b</div>",
576577
[["inserthtml","<span></span>"]],
577-
"<div>a<span></span>b</div>",
578+
["<div>a<span></span>b</div>","<div>a<span></span>b<br></div>"],
578579
[true],
579580
{"inserthtml":[false,false,"",false,false,""]}],
580581
["<div>a[]c</div>",
581582
[["inserthtml","<span class=\"s1\"></span>b<span class=\"s2\"></span>"]],
582-
"<div>a<span class=\"s1\"></span>b<span class=\"s2\"></span>c</div>",
583+
["<div>a<span class=\"s1\"></span>b<span class=\"s2\"></span>c</div>",
584+
"<div>a<span class=\"s1\"></span>b<span class=\"s2\"></span>c<br></div>"],
583585
[true],
584586
{"inserthtml":[false,false,"",false,false,""]}],
585587
["{}",

0 commit comments

Comments
 (0)