Skip to content

Commit ec0bc19

Browse files
natechapinchromium-wpt-export-bot
authored andcommitted
Revert "Reapply "Use typed promises/resolvers for ReadableStream and related classes""
This reverts commit 39adf0544a3fbfcce710b0490d3825174c0c6e12. Reason for revert: Crashes in the wild: crbug.com/332806529 Original change's description: > Reapply "Use typed promises/resolvers for ReadableStream and related classes" > > This converts IDL-exposed promises in ReadableStream, > ReadableStreamBYOBReader, ReadableStreamDefaultReader, and > ReadableStreamGenericReader to use typed ScriptPromiseResolver > instead of StreamPromiseResolver and to return typed > ScriptPromises. > > Bug: 329702363 > Change-Id: I6dad0ce6902c2dd5411185800bdd5a6dd8585df8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5410703 > Reviewed-by: Nidhi Jaju <[email protected]> > Commit-Queue: Nate Chapin <[email protected]> > Reviewed-by: Adam Rice <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1281906} Bug: 329702363 Change-Id: I2a70811f87d844a1686fc082d67c8dbc473f91c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5427820 Commit-Queue: Nate Chapin <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/heads/main@{#1283318}
1 parent c3bc1b0 commit ec0bc19

File tree

3 files changed

+2
-24
lines changed

3 files changed

+2
-24
lines changed

long-animation-frame/tentative/loaf-stream-source-location.html

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,7 @@ <h1>Long Animation Frame: source location extraction for streams</h1>
1717
const scriptElement = document.createElement("script");
1818
scriptElement.src = scriptLocation;
1919
document.body.appendChild(scriptElement);
20-
}, script => {
21-
return script.invoker === "Promise.resolve" }, t);
20+
}, script => script.invoker === "StreamPromise.resolve.then", t);
2221

2322
assert_true(script.sourceURL.includes("stream-promise-generates-loaf.js"));
2423
}, "Source location should be extracted for stream promises");

long-animation-frame/tentative/loaf-stream.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,6 @@ <h1>Long Animation Frame: stream promise resolvers</h1>
3434
});
3535
response.body.pipeTo(writable);
3636
await readable.getReader().read();
37-
}, "resolve", "Promise.resolve");
37+
}, "resolve", "StreamPromise.resolve");
3838
</script>
3939
</body>

streams/piping/detached-context-crash.html

Lines changed: 0 additions & 21 deletions
This file was deleted.

0 commit comments

Comments
 (0)