Skip to content

Commit fe7656c

Browse files
authored
Ignore WEB_FEATURES.yml for update-wasm-tests workflow (#55040)
Currently, the update-wasm-tests workflow removes all the existing WASM test files before copying over the new tests. This means that we cannot land WEB_FEATURES.yml files for WASM because they would be removed during the next run of the workflow. This change moves to using rsync and excludes WEB_FEATURES.yml files. This will allow WEB_FEATURES.yml files to persist between workflow runs. Given these generated PRs are still manually reviewed, incoming PRs with changes to the file names will be caught by the WEB_FEATURES linter And reviewers can update them if needed.
1 parent 5279c01 commit fe7656c

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

.github/workflows/update-wasm-tests.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,9 @@ jobs:
3030
- name: Convert WAST tests to WPT
3131
run: wasm-spec/test/build.py --dont-recompile --html wasm-spec/out/
3232
- name: Copy Wasm tests to WPT
33-
# Replace wasm/core entirely.
33+
# Replace wasm/core entirely, but preserve WEB_FEATURES.yml files.
3434
run: |
35-
rm -rf wpt/wasm/core
36-
cp -r wasm-spec/out/ wpt/wasm/core/
35+
rsync -a --delete --exclude 'WEB_FEATURES.yml' wasm-spec/out/ wpt/wasm/core/
3736
- name: Commit changes
3837
id: commit
3938
continue-on-error: true

0 commit comments

Comments
 (0)