[Origin API] Drop string parsers beyond .from(...).
#56301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier versions of this API parsed strings into `Origin` objects via the constructor, `fromURL()` and `parse()`. We've since coalesced all of these into `Origin.from(...)` after discussion in [1]. This CL removes these variants from our implementation, and adjusts tests accordingly. [1]: whatwg/html#11846 Bug: 434131026 Change-Id: I8be1e1a0923b2cd48dcc7a0f80358237ecc9b88c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7204253 Commit-Queue: Mike West <[email protected]> Reviewed-by: Antonio Sartori <[email protected]> Cr-Commit-Position: refs/heads/main@{#1550470}
wpt-pr-bot
approved these changes
Nov 26, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier versions of this API parsed strings into
Originobjects viathe constructor,
fromURL()andparse(). We've since coalesced all ofthese into
Origin.from(...)after discussion in 1.This CL removes these variants from our implementation, and adjusts
tests accordingly.
Bug: 434131026
Change-Id: I8be1e1a0923b2cd48dcc7a0f80358237ecc9b88c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7204253
Commit-Queue: Mike West <[email protected]>
Reviewed-by: Antonio Sartori <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1550470}