Releases: web-platform-tests/wpt
merge_pr_54804
Reland "Send dropEffect attribute on drag and drop events"
This is a reland of commit 0542983115c4ccbaa2b1dd15faff2675d520bbeb
Reason for reland: This CL was erroneously assigned blame for flakiness
in some tests Drag and Drop browser tests in chromeos and linux. See
bug: https://crbug.com/442927728
Original change's description:
Send dropEffect attribute on drag and drop events
This CL implements the dropEffect attribute in the dataTransfer property
in drag and drop event to match the spec.
https://html.spec.whatwg.org/multipage/dnd.htmlThe attribute is currently not being set, defaulting to "none" on all
events.Many existing tests were updated to pass with the new implementation.
Notably, the default dropEffect for some "effectAllowed" attributes has
been changed to match the defaults in the table found in "6.11.4 The
DragEvent interface" in the spec. (defaulting to copy whenever copy is
available, and to link if link is available)Bug: 434151262
Change-Id: Iaeaa7e0e4b9a44e89379b6adf72650ab89fe3dd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6803149
Commit-Queue: Gaston Rodriguez [email protected]
Reviewed-by: Avi Drissman [email protected]
Reviewed-by: Olga Gerchikov [email protected]
Reviewed-by: Kent Tamura [email protected]
Cr-Commit-Position: refs/heads/main@{#1509844}
Bug: 434151262
Change-Id: Id77db2432864ce8ba8f27b7fd216fd21145791b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6935426
Commit-Queue: Gaston Rodriguez [email protected]
Reviewed-by: Avi Drissman [email protected]
Reviewed-by: Olga Gerchikov [email protected]
Reviewed-by: Kent Tamura [email protected]
Cr-Commit-Position: refs/heads/main@{#1513989}
merge_pr_54803
[webaudio-testharness] Migrate adding-events.html
Convert adding-events.html from the legacy audit.js runner to
pure testharness.js
Change-Id: Ie4a6a3cc3cc7c41bfda2f968b631d5d5c7130425
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6918437
Commit-Queue: Punith Nayak [email protected]
Reviewed-by: Hongchan Choi [email protected]
Reviewed-by: Alvin Ji [email protected]
Cr-Commit-Position: refs/heads/main@{#1513984}
merge_pr_54802
[Masonry] Expand grid template track definitions
In grid, grid-template* computes to its expanded track definition. In
Masonry, we were not expanding these, since ComputedStyleUtils:: ValueForGridTrackList()
only supported LayoutGrid. This change adjusts
this method to a template that takes either LayoutGrid or LayoutMasonry
and ensures that both classes support the methods needed for
ComputedStyleUtils::ValueForGridTrackList()
.
This also required updating the grid-template* properties to be layout
dependent if masonry or grid, otherwise, we didn't end up having access
to LayoutData in ComputedStyleUtils::ValueForGridTrackList()
.
A number of wpt tests that relied on this are now passing for intrinsic
auto repeats, and a few computed style wpts were added for intrinsic
auto repeats as part of this change. Some of which had the wrong
expectation file, so those have been updated, too.
There is one test marked as failing because we are resolving %'s to a
value I wouldn't expect. There was also one crashing when getting the
number of intrinsic auto repeats. These failures are unrelated to this
change, so I will investigate these in a separate CL.
Bug: 343257585
Change-Id: If4e7680dd4abb7367ee44ccc3cdf98f1efb8f5d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6925900
Reviewed-by: Kurt Catti-Schmidt [email protected]
Commit-Queue: Alison Maher [email protected]
Cr-Commit-Position: refs/heads/main@{#1513953}
merge_pr_54801
Add support for drag-and-drop tests on scrollbars
This expands the drag-and-drop test helpers to support cases where the
drop target is a scrollbar, not just the center of an element. It fixes
existing tests designed to exercise drag-and-drop interactions with
element scrollbars, ensuring they now test the correct scenario. This
change adds movePointerToScrollbar, and other related helper functions.
Bug: 426228061,426054999
Change-Id: Id7f80247097dcf78b545f1fb69643e4eb6c25e0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6821200
Reviewed-by: Gaston Rodriguez [email protected]
Reviewed-by: Mustaq Ahmed [email protected]
Commit-Queue: Eain Chen [email protected]
Cr-Commit-Position: refs/heads/main@{#1513936}
merge_pr_54799
ScopedVT: Set view-transition-name: root on scope element.
Bug: 434762432
Change-Id: Id043c40f6e6497845498bfb044d5ee8514ddfd4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6927722
Commit-Queue: Steve Kobes [email protected]
Reviewed-by: Vladimir Levin [email protected]
Cr-Commit-Position: refs/heads/main@{#1513837}
merge_pr_54798
[webaudio-testharness] Migrate active-processing.https.html
Convert third_party/blink/web_tests/external/wpt/webaudio
/the-audio-api/the-audiobuffersourcenode-interface
/active-processing.https.html from the legacy audit.js runner to pure
testharness.js
Bug: 396477778
Change-Id: Iaebd593bf43e48da82688e3444e68ece66d1b020
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6905376
Reviewed-by: Matt Reynolds [email protected]
Reviewed-by: Hongchan Choi [email protected]
Commit-Queue: Hongchan Choi [email protected]
Cr-Commit-Position: refs/heads/main@{#1513780}
merge_pr_54797
Use NewObject for Blob methods that return new instances
This change updates the IDL to match the W3C spec by explicitly marking
methods that always return a new object with NewObject.
This CL has no behavior changes.
Bug: 436420911
Change-Id: I42d3c048f3dd1edae2ae4fd4f791fd127d807d8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6824263
Reviewed-by: Fergal Daly [email protected]
Reviewed-by: Jinho Bang [email protected]
Commit-Queue: Jinho Bang [email protected]
Cr-Commit-Position: refs/heads/main@{#1513751}
merge_pr_54796
[CodeHealth] Refactor pointerevent_pointerrawupdate.https.html
This is a no-op CL to improve the WPT for secure contexts:
- Replaces the state-machine based assertions with a simple event
order assertion, which also adds the missing coverage for "one
pointerrawupdate per pointermove" (as per
https://w3c.github.io/pointerevents/#the-pointerrawupdate-event ). - Adds the coverage for global event listeners.
- Ports old-style tests to promise_tests and "use strict".
(Confirmed manually that Firefox passes the test before and after.)
Bug: 404479704
Change-Id: I8dfb473b87872424fdb992ef5bc4ed0587949f45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6936027
Auto-Submit: Mustaq Ahmed [email protected]
Reviewed-by: Kevin Ellis [email protected]
Commit-Queue: Kevin Ellis [email protected]
Cr-Commit-Position: refs/heads/main@{#1513732}
merge_pr_54794
Don't try to sort complex-typed CSS math operations based on its unit
When simplifying math expressions for sum or product we should normally
sort each component of the expression based on its type, e.g. 1rem + 1px
- 1em should become 1em + 1px + 1rem. However, when we have a
complex-typed expression (e.g. 1rem / 1px * 1px) the spec is not clear
about which type should be used for sorting. This leads to the crash in
our code when we call ResolvedUnitTypeForSimplification, as that
function doesn't know how to get a type of a typed expression.
So, this CL treats such complex-typed expressions as other expressions
that can't be sorted based on its type (such as css math functions, e.g.
sign()), meaning that sorting first puts numeric values sorted by their
alphabetical order of units and then it puts every other expression in
the same order it appeared in the original expression.
Also, this CL moves calls to ResolvedUnitTypeForSimplification close to
where it will be used (with numeric literals with double value), so that
for complex-typed expressions we don't call that function.
The test case also has 1px * 1px / 1px which should be simplified to
just 1px, but that is out of the scope of this CL.
Fixed: 443107131
Change-Id: I4078cd9d644b517d0ed0147beb2214118436750f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6919380
Reviewed-by: Steinar H Gunderson [email protected]
Commit-Queue: Daniil Sakhapov [email protected]
Cr-Commit-Position: refs/heads/main@{#1513663}
merge_pr_54791
Sync interfaces/ with @webref/idl 3.67.1 (#54791)
Co-authored-by: wpt-pr-bot [email protected]