Add ConfigureAwait(false) to all async calls

Author: coryjthompson

WebPush/WebPushClient.cs

@@ -284,7 +284,7 @@ private static EncryptionResult EncryptPayload(PushSubscription subscription, st
         public void SendNotification(PushSubscription subscription, string payload = null,
             Dictionary<string, object> options = null)
         {
-            SendNotificationAsync(subscription, payload, options).GetAwaiter().GetResult();
+            SendNotificationAsync(subscription, payload, options).ConfigureAwait(false).GetAwaiter().GetResult();
         }
 
         /// <summary>
@@ -329,9 +329,9 @@ public async Task SendNotificationAsync(PushSubscription subscription, string pa
             Dictionary<string, object> options = null, CancellationToken cancellationToken = default)
         {
             var request = GenerateRequestDetails(subscription, payload, options);
-            var response = await HttpClient.SendAsync(request, cancellationToken);
+            var response = await HttpClient.SendAsync(request, cancellationToken).ConfigureAwait(false);
 
-            HandleResponse(response, subscription);
+            await HandleResponse(response, subscription).ConfigureAwait(false);
         }
 
         /// <summary>
@@ -346,7 +346,7 @@ public async Task SendNotificationAsync(PushSubscription subscription, string pa
             VapidDetails vapidDetails, CancellationToken cancellationToken = default)
         {
             var options = new Dictionary<string, object> { ["vapidDetails"] = vapidDetails };
-            await SendNotificationAsync(subscription, payload, options, cancellationToken);
+            await SendNotificationAsync(subscription, payload, options, cancellationToken).ConfigureAwait(false);
         }
 
         /// <summary>
@@ -360,15 +360,15 @@ public async Task SendNotificationAsync(PushSubscription subscription, string pa
         public async Task SendNotificationAsync(PushSubscription subscription, string payload, string gcmApiKey, CancellationToken cancellationToken = default)
         {
             var options = new Dictionary<string, object> { ["gcmAPIKey"] = gcmApiKey };
-            await SendNotificationAsync(subscription, payload, options, cancellationToken);
+            await SendNotificationAsync(subscription, payload, options, cancellationToken).ConfigureAwait(false);
         }
 
         /// <summary>
         ///     Handle Web Push responses.
         /// </summary>
         /// <param name="response"></param>
         /// <param name="subscription"></param>
-        private static void HandleResponse(HttpResponseMessage response, PushSubscription subscription)
+        private static async Task HandleResponse(HttpResponseMessage response, PushSubscription subscription)
         {
             // Successful
             if (response.IsSuccessStatusCode)
@@ -398,7 +398,12 @@ private static void HandleResponse(HttpResponseMessage response, PushSubscriptio
                     break;
             }
 
-            var details = response.Content?.ReadAsStringAsync().GetAwaiter().GetResult();
+            string details = null;
+            if (response.Content != null)
+            {
+                details = await response.Content.ReadAsStringAsync().ConfigureAwait(false); 
+            }
+
             var message = string.IsNullOrEmpty(details)
                 ? responseCodeMessage
                 : $"{responseCodeMessage}. Details: {details}";