Merge pull request #155 from marco-c/automatically_download_and_execute_selenium_server

Automatically download and execute Selenium server

Author: marco-c

.travis.yml

@@ -17,8 +17,6 @@ before_install:
   - nvm install $NODE_VERSION
   - export NODE=$(nvm which $NODE_VERSION)
   - export NPM=${NODE%node}npm
-  - wget http://selenium-release.storage.googleapis.com/2.53/selenium-server-standalone-2.53.0.jar
-  - java -jar selenium-server-standalone-2.53.0.jar &> /dev/null &
 install:
   - $NPM install
   - $NPM install mocha

README.md

@@ -63,25 +63,13 @@ The [Service Worker Cookbook](https://serviceworke.rs/) is full of Web Push exam
 
 #### Prerequisites:
   * Java JDK or JRE (http://www.oracle.com/technetwork/java/javase/downloads/index.html)
-  * Selenium Server 2.53.0 ([Download](http://selenium-release.storage.googleapis.com/2.53/selenium-server-standalone-2.53.0.jar))
-
-### Setup
-
-* Run Selenium Server
-
-e.g. in shell form:
-
-```sh
-java -jar selenium-server-standalone-2.53.0.jar
-```
-
-To run tests locally with Selenium:
 
+To run tests:
 ```sh
 npm test
 ```
 
 In order to make the tests run in Chromium/Chrome, you need a GCM API key and you need to define a GCM_API_KEY environment variable:
-```
+```sh
 GCM_API_KEY=your_API_key npm test
 ```

test/selenium-init.js

@@ -279,11 +279,18 @@ function downloadChromeDriver() {
   });
 }
 
+// Download Selenium server
+
+function downloadSeleniumServer() {
+  return wget(destDir, 'https://selenium-release.storage.googleapis.com/2.53/selenium-server-standalone-2.53.0.jar');
+}
+
 module.exports = {
   downloadFirefoxNightly: downloadFirefoxNightly,
   downloadFirefoxRelease: downloadFirefoxRelease,
   downloadFirefoxBeta: downloadFirefoxBeta,
   downloadFirefoxAurora: downloadFirefoxAurora,
   downloadChromiumNightly: downloadChromiumNightly,
   downloadChromeDriver: downloadChromeDriver,
+  downloadSeleniumServer: downloadSeleniumServer,
 };

test/testSelenium.js

@@ -6,6 +6,7 @@ var temp = require('temp').track();
 var colors = require('colors');
 var semver = require('semver');
 var childProcess = require('child_process');
+var net = require('net');
 var seleniumInit = require('./selenium-init');
 var createServer = require('./server');
 var webPush = require('../index.js');
@@ -24,6 +25,25 @@ if (!process.env.VAPID_PRIVATE_KEY || !process.env.VAPID_PUBLIC_KEY) {
 
 process.env.PATH = process.env.PATH + ':test_tools/';
 
+function isPortOpen(port) {
+  return new Promise(function(resolve, reject) {
+    var socket = new net.Socket();
+
+    socket.on('connect', function() {
+      socket.end();
+      resolve(true);
+    });
+
+    socket.on('error', function() {
+      resolve(false);
+    });
+
+    socket.connect({
+      port: port,
+    });
+  });
+}
+
 suite('selenium', function() {
   var webdriver = require('selenium-webdriver');
   var firefox = require('selenium-webdriver/firefox');
@@ -140,6 +160,8 @@ suite('selenium', function() {
 
     promises.push(seleniumInit.downloadFirefoxNightly());
 
+    promises.push(seleniumInit.downloadSeleniumServer());
+
     if (process.env.GCM_API_KEY) {
       if (process.platform === 'linux') {
         chromeBinaryPath = 'test_tools/chrome-linux/chrome';
@@ -178,6 +200,29 @@ suite('selenium', function() {
         console.log('Using Chromium: ' + chromeBinaryPath);
         console.log('Version: ' + childProcess.execSync(chromeBinaryPath + ' --version').toString().replace('\n', ''));
       } catch (e) {}
+
+      if (!fs.existsSync('test_tools/selenium-server-standalone-2.53.0.jar')) {
+        throw new Error('Selenium server doesn\'t exist.');
+      }
+
+      childProcess.exec('java -jar test_tools/selenium-server-standalone-2.53.0.jar');
+
+      // Return a promise that resolved once the Selenium server is listening to the port 4444.
+      return new Promise(function(resolve, reject) {
+        var timerID = setInterval(function() {
+          isPortOpen(4444)
+          .then(function(isOpen) {
+            if (isOpen) {
+              clearInterval(timerID);
+              resolve();
+            }
+          })
+          .catch(function() {
+            clearInterval(timerID);
+            reject();
+          });
+        }, 1000);
+      })
     });
   });