Skip to content

Commit 3431523

Browse files
committed
Merge pull request #136 from marco-c/remove_chrome_env_var
Remove CHROME env var
2 parents 02d45c7 + 5819a24 commit 3431523

File tree

2 files changed

+8
-14
lines changed

2 files changed

+8
-14
lines changed

.travis.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ env:
77
- MOZ_XVFB=$(if [[ $TRAVIS_OS_NAME == "linux" ]]; then echo 1; fi)
88
matrix:
99
- NODE_VERSION="0.12"
10-
- NODE_VERSION="4" CHROME="nightly"
11-
- NODE_VERSION="stable" CHROME="nightly"
10+
- NODE_VERSION="4"
11+
- NODE_VERSION="stable"
1212
before_install:
1313
- rm -rf ~/.nvm
1414
- git clone https://github.com/creationix/nvm.git ~/.nvm && (cd ~/.nvm && git checkout `git describe --abbrev=0 --tags`)

test/testSelenium.js

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -131,20 +131,14 @@ suite('selenium', function() {
131131
promises.push(seleniumInit.downloadFirefoxNightly());
132132

133133
if (process.env.GCM_API_KEY) {
134-
chromeBinaryPath = process.env.CHROME;
135-
if (chromeBinaryPath === 'nightly') {
136-
if (process.platform === 'linux') {
137-
chromeBinaryPath = 'test_tools/chrome-linux/chrome';
138-
} else if (process.platform === 'darwin') {
139-
chromeBinaryPath = 'test_tools/chrome-mac/Chromium.app/Contents/MacOS/Chromium';
140-
}
141-
142-
promises.push(seleniumInit.downloadChromiumNightly());
143-
} else if (chromeBinaryPath === 'all') {
144-
// TODO: Download Chromium release.
145-
chromeBinaryPath = childProcess.execSync('which chromium-browser').toString().replace('\n', '');
134+
if (process.platform === 'linux') {
135+
chromeBinaryPath = 'test_tools/chrome-linux/chrome';
136+
} else if (process.platform === 'darwin') {
137+
chromeBinaryPath = 'test_tools/chrome-mac/Chromium.app/Contents/MacOS/Chromium';
146138
}
147139

140+
promises.push(seleniumInit.downloadChromiumNightly());
141+
148142
promises.push(seleniumInit.downloadChromeDriver());
149143
}
150144

0 commit comments

Comments
 (0)