Merge pull request #187 from web-push-libs/gcm_api_key_sanity_checks

Add basic sanity checks for the GCM API key.

Author: marco-c

index.js

@@ -92,6 +92,10 @@ require('util').inherits(WebPushError, Error);
 var gcmAPIKey = '';
 
 function setGCMAPIKey(apiKey) {
+  if (!apiKey || typeof apiKey !== 'string') {
+    throw new Error('The GCM API Key should be a non-emtpy string.');
+  }
+
   gcmAPIKey = apiKey;
 }
 

test/testSetGCMAPIKey.js

@@ -6,7 +6,15 @@ suite('setGCMAPIKey', function() {
     assert(webPush.setGCMAPIKey);
   });
 
-  test('call', function() {
-    webPush.setGCMAPIKey('hello');
-  })
+  test('non-empty string', function() {
+    assert.doesNotThrow(function() { webPush.setGCMAPIKey('AIzaSyAwmdX6KKd4hPfIcGU2SOfj9vuRDW6u-wo') });
+  });
+
+  test('empty string', function() {
+    assert.throws(function() { webPush.setGCMAPIKey('') }, Error);
+  });
+
+  test('non string', function() {
+    assert.throws(function() { webPush.setGCMAPIKey(42) }, Error);
+  });
 });