Skip to content

Commit 5be867e

Browse files
author
Matt Gaunt
committed
Try out new geckodriver
1 parent 9ebc7a1 commit 5be867e

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@
4949
"eslint-config-airbnb": "^9.0.1",
5050
"eslint-plugin-import": "^1.11.1",
5151
"fs-extra": "^0.30.0",
52+
"geckodriver": "^1.1.2",
5253
"istanbul": "^0.4.2",
5354
"mkdirp": "^0.5.1",
5455
"mocha": "^2.4.5",

test/helpers/download-test-browsers.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
}
1818

1919
const promises = [
20-
seleniumAssistant.downloadFirefoxDriver(),
2120
seleniumAssistant.downloadBrowser('firefox', 'stable', forceDownload),
2221
seleniumAssistant.downloadBrowser('firefox', 'beta', forceDownload),
2322
seleniumAssistant.downloadBrowser('firefox', 'unstable', forceDownload),
@@ -31,7 +30,7 @@
3130
console.log('Download complete.');
3231
})
3332
.catch(function(err) {
34-
console.error('Unable to download browsers and Geckodriver.', err);
33+
console.error('Unable to download browsers.', err);
3534
process.exit(1);
3635
});
3736
})();

test/testSelenium.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,9 @@
2020
const webPush = require('../src/index');
2121
const createServer = require('./helpers/create-server');
2222
const which = require('which');
23+
24+
// We need geckodriver on the path
25+
require('geckodriver');
2326
/* eslint-enable global-require */
2427

2528
const PUSH_TEST_TIMEOUT = 120 * 1000;

0 commit comments

Comments
 (0)