Throw error if userPublicKey (or userAuth) is defined but isn't a string

Author: marco-c

index.js

@@ -148,6 +148,14 @@ function sendNotification(endpoint, params) {
         console.warn('You are using the old, deprecated, interface of the `sendNotification` function.'.bold.red);
       }
 
+      if (typeof userPublicKey !== 'undefined' && typeof userPublicKey !== 'string') {
+        throw new Error('userPublicKey should be a base64-encoded string.');
+      }
+
+      if (typeof userAuth !== 'undefined' && typeof userAuth !== 'string') {
+        throw new Error('userAuth should be a base64-encoded string.');
+      }
+
       const isGCM = endpoint.indexOf('https://android.googleapis.com/gcm/send') === 0;
 
       var urlParts = url.parse(endpoint);

test/testSendNotification.js

@@ -421,6 +421,32 @@ suite('sendNotification', function() {
     });
   });
 
+  test('invalid userPublicKey arguments', function() {
+    return webPush.sendNotification('https://127.0.0.1:' + serverPort, {
+      userPublicKey: userPublicKey,
+      userAuth: urlBase64.encode(userAuth),
+      payload: 'hello',
+    })
+    .then(function(body) {
+      assert(false, 'sendNotification promise resolved');
+    }, function() {
+      assert(true, 'sendNotification promise rejected');
+    });
+  });
+
+  test('invalid userAuth arguments', function() {
+    return webPush.sendNotification('https://127.0.0.1:' + serverPort, {
+      userPublicKey: urlBase64.encode(userPublicKey),
+      userAuth: userAuth,
+      payload: 'hello',
+    })
+    .then(function(body) {
+      assert(false, 'sendNotification promise resolved');
+    }, function() {
+      assert(true, 'sendNotification promise rejected');
+    });
+  });
+
   test('TTL with old interface', function() {
     return startServer(undefined, 5)
     .then(function() {