Skip to content

Commit 8ceae6c

Browse files
committed
Remove 0.10-0.12 specific checks from tests
1 parent e261ff0 commit 8ceae6c

File tree

3 files changed

+5
-23
lines changed

3 files changed

+5
-23
lines changed

test/helpers/download-test-browsers.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,6 @@
11
'use strict';
22

33
(function() {
4-
const invalidNodeVersions = /0.(10|12).(\d+)/;
5-
if (process.versions.node.match(invalidNodeVersions)) {
6-
console.log('Skipping downloading browsers as selenium tests can\'t run on ' + process.versions.node);
7-
return null;
8-
}
9-
104
/* eslint-disable global-require*/
115
const seleniumAssistant = require('selenium-assistant');
126
/* eslint-enable global-require*/

test/testSelenium.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,6 @@
11
'use strict';
22

33
(function() {
4-
const invalidNodeVersions = /0.(10|12).(\d+)/;
5-
if (process.versions.node.match(invalidNodeVersions)) {
6-
console.log('Skipping downloading browsers as selenium tests can\'t run on ' + process.versions.node);
7-
return;
8-
}
9-
104
/* eslint-disable global-require */
115
const seleniumAssistant = require('selenium-assistant');
126
const webdriver = require('selenium-webdriver');

test/testSendNotification.js

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ const fs = require('fs');
77
const path = require('path');
88
const ece = require('http_ece');
99
const urlBase64 = require('urlsafe-base64');
10-
const semver = require('semver');
1110
const portfinder = require('portfinder');
1211
const jws = require('jws');
1312

@@ -274,14 +273,7 @@ suite('sendNotification', function() {
274273
}
275274
}
276275
}
277-
}
278-
];
279-
280-
// TODO: Add test for VAPID override
281-
282-
// This test fails on Node.js v0.12.
283-
if (!semver.satisfies(process.version, '0.12')) {
284-
validRequests.push({
276+
}, {
285277
testTitle: 'send/receive empty message',
286278
requestOptions: {
287279
subscription: {
@@ -292,8 +284,10 @@ suite('sendNotification', function() {
292284
TTL: 5
293285
}
294286
}
295-
});
296-
}
287+
}
288+
];
289+
290+
// TODO: Add test for VAPID override
297291

298292
validRequests.forEach(function(validRequest) {
299293
test(validRequest.testTitle, function() {

0 commit comments

Comments
 (0)