Skip to content

Commit a438ce7

Browse files
committed
Merge pull request #165 from marco-c/set_keys_in_tests
Define GCM and VAPID keys directly in tests.
2 parents bff1648 + c4ae61a commit a438ce7

File tree

2 files changed

+8
-22
lines changed

2 files changed

+8
-22
lines changed

test/browser-managers/chrome-browsers.js

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,10 @@ function ChromeBrowsers() {
3131
}
3232

3333
this.downloadBrowsers = function() {
34-
var promises = [];
35-
if (process.env.GCM_API_KEY) {
36-
promises.push(seleniumInit.downloadChromiumNightly());
37-
promises.push(seleniumInit.downloadChromeDriver());
38-
}
39-
return Promise.all(promises);
34+
return Promise.all([
35+
seleniumInit.downloadChromiumNightly(),
36+
seleniumInit.downloadChromeDriver(),
37+
]);
4038
}
4139

4240
this.getBrowserDriver = function(browserId, testServerURL) {

test/testSelenium.js

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,7 @@ var webPush = require('../index');
22
var createServer = require('./helpers/create-server');
33
var isPortOpen = require('./helpers/port-open');
44

5-
if (!process.env.GCM_API_KEY) {
6-
console.log('You need to set the GCM_API_KEY env variable to run the tests with Chromium.'.bold.red);
7-
} else {
8-
webPush.setGCMAPIKey(process.env.GCM_API_KEY);
9-
}
10-
11-
if (!process.env.VAPID_PRIVATE_KEY || !process.env.VAPID_PUBLIC_KEY) {
12-
console.log('You haven\'t set the VAPID env variables, I\'ll generate them for you.'.bold.yellow);
13-
14-
var keys = webPush.generateVAPIDKeys();
15-
process.env.VAPID_PRIVATE_KEY = keys.privateKey.toString('base64');
16-
process.env.VAPID_PUBLIC_KEY = keys.publicKey.toString('base64');
17-
}
5+
webPush.setGCMAPIKey('AIzaSyAwmdX6KKd4hPfIcGU2SOfj9vuRDW6u-wo');
186

197
process.env.PATH = process.env.PATH + ':test_tools/';
208

@@ -34,8 +22,8 @@ suite('selenium', function() {
3422
var VAPID_PARAM = {
3523
audience: 'https://www.mozilla.org/',
3624
subject: 'mailto:[email protected]',
37-
privateKey: new Buffer(process.env.VAPID_PRIVATE_KEY, 'base64'),
38-
publicKey: new Buffer(process.env.VAPID_PUBLIC_KEY, 'base64'),
25+
privateKey: new Buffer('H6tqEMswzHOFlPHFi2JPfDQRiKN32ZJIwvSPWZl1VTA=', 'base64'),
26+
publicKey: new Buffer('BIx6khu9Z/5lBwNEXYNEOQiL70IKYDpDxsTyoiCb82puQ/V4c/NFdyrBFpWdsz3mikmV6sWARNuhRbbbLTMOmB0=', 'base64'),
3927
};
4028
var globalServer, globalDriver;
4129

@@ -152,7 +140,7 @@ suite('selenium', function() {
152140
browserDrivers.push(browserInfo);
153141
});
154142

155-
if (process.env.GCM_API_KEY && process.env.TRAVIS_OS_NAME !== 'osx') {
143+
if (process.env.TRAVIS_OS_NAME !== 'osx') {
156144
chromeBrowsersToTest.forEach(function(browserInfo) {
157145
browserInfo.getBrowserDriver = function() {
158146
return chromeBrowsers.getBrowserDriver(browserInfo.id, 'http://127.0.0.1:' + globalServer.port);

0 commit comments

Comments
 (0)