Make TTL option accept zero as a value (#492)

renegadeHomie · marco-c · marco-c · commit cf3d3de543be · 2019-09-04T10:51:01.000+02:00
Co-Authored-By: Marco &lt;mcastelluccio@mozilla.com&gt;
diff --git a/src/web-push-lib.js b/src/web-push-lib.js
@@ -155,8 +155,11 @@ WebPushLib.prototype.generateRequestDetails = function(subscription, payload, op
         currentVapidDetails = options.vapidDetails;
       }
 
-      if (options.TTL) {
-        timeToLive = options.TTL;
+      if (options.TTL !== undefined) {
+        timeToLive = Number(options.TTL);
+        if (timeToLive < 0) {
+          throw new Error('TTL should be a number and should be at least 0');
+        }
       }
 
       if (options.contentEncoding) {

Original file line number	Diff line number	Diff line change
`@@ -155,8 +155,11 @@ WebPushLib.prototype.generateRequestDetails = function(subscription, payload, op`
`155`	`155`	`currentVapidDetails = options.vapidDetails;`
`156`	`156`	`}`
`157`	`157`
`158`		`- if (options.TTL) {`
`159`		`- timeToLive = options.TTL;`
	`158`	`+ if (options.TTL !== undefined) {`
	`159`	`+ timeToLive = Number(options.TTL);`
	`160`	`+ if (timeToLive < 0) {`
	`161`	`+ throw new Error('TTL should be a number and should be at least 0');`
	`162`	`+ }`
`160`	`163`	`}`
`161`	`164`
`162`	`165`	`if (options.contentEncoding) {`