Adding tests for setVapidDetails

Author: Matt Gaunt

src/web-push-lib.js

@@ -55,6 +55,36 @@ WebPushLib.prototype.setVapidDetails =
       return;
     }
 
+    if (typeof subject !== 'string' || subject.length === 0) {
+      throw new Error('The subject should be a URL or mailto:');
+    }
+
+    if (subject.indexOf('mailto:') !== 0) {
+      // Must be a url if it doesn't have mailto at the start
+      const subjectParseResult = url.parse(subject);
+      if (!subjectParseResult.hostname) {
+        throw new Error('Vapid subject is not a url or mailto url. ' + subject);
+      }
+    }
+
+    if (typeof publicKey !== 'string') {
+      throw new Error('The vapid public key must be a url safe Base 64 ' +
+        'encoded string.');
+    }
+
+    if (urlBase64.decode(publicKey).length !== 65) {
+      throw new Error('The vapid public key must be 65 bytes once decoded.');
+    }
+
+    if (typeof privateKey !== 'string') {
+      throw new Error('The vapid private key must be a url safe Base 64 ' +
+        'encoded string.');
+    }
+
+    if (urlBase64.decode(privateKey).length !== 32) {
+      throw new Error('The vapid private key must be 65 bytes once decoded.');
+    }
+
     vapidDetails = {
       subject: subject,
       publicKey: publicKey,

test/test-set-vapid-details.js

@@ -0,0 +1,119 @@
+'use strict';
+
+const assert = require('assert');
+const urlBase64 = require('urlsafe-base64');
+const webPush = require('../src/index');
+
+const VALID_SUBJECT_MAILTO = 'mailto: [email protected]';
+const VALID_SUBJECT_URL = 'https://exampe.com/contact';
+const VALID_PUBLIC_KEY = urlBase64.encode(new Buffer(65));
+const VALID_PRIVATE_KEY = urlBase64.encode(new Buffer(32));
+
+suite('setVapidDetails()', function() {
+  test('is defined', function() {
+    assert(webPush.setVapidDetails);
+  });
+
+  test('Valid URL input', function() {
+    assert.doesNotThrow(function() {
+      webPush.setVapidDetails(VALID_SUBJECT_URL, VALID_PUBLIC_KEY, VALID_PRIVATE_KEY);
+    });
+  });
+
+  test('Valid mailto: input', function() {
+    assert.doesNotThrow(function() {
+      webPush.setVapidDetails(VALID_SUBJECT_MAILTO, VALID_PUBLIC_KEY, VALID_PRIVATE_KEY);
+    });
+  });
+
+  test('reset Vapid Details with null', function() {
+    assert.doesNotThrow(function() {
+      webPush.setVapidDetails(null);
+    });
+  });
+
+  const invalidInputs = [
+    {
+      subject: '',
+      publicKey: VALID_PUBLIC_KEY,
+      privateKey: VALID_PRIVATE_KEY
+    },
+    {
+      subject: 'This is not a valid subject',
+      publicKey: VALID_PUBLIC_KEY,
+      privateKey: VALID_PRIVATE_KEY
+    },
+    {
+      subject: {},
+      publicKey: VALID_PUBLIC_KEY,
+      privateKey: VALID_PRIVATE_KEY
+    },
+    {
+      subject: true,
+      publicKey: VALID_PUBLIC_KEY,
+      privateKey: VALID_PRIVATE_KEY
+    },
+    {
+      subject: VALID_SUBJECT_URL,
+      publicKey: urlBase64.encode(new Buffer(60)),
+      privateKey: VALID_PRIVATE_KEY
+    },
+    {
+      subject: VALID_SUBJECT_URL,
+      publicKey: 'This is invalid',
+      privateKey: VALID_PRIVATE_KEY
+    },
+    {
+      subject: VALID_SUBJECT_URL,
+      publicKey: '',
+      privateKey: VALID_PRIVATE_KEY
+    },
+    {
+      subject: VALID_SUBJECT_URL,
+      publicKey: {},
+      privateKey: VALID_PRIVATE_KEY
+    },
+    {
+      subject: VALID_SUBJECT_URL,
+      publicKey: true,
+      privateKey: VALID_PRIVATE_KEY
+    },
+    {
+      subject: VALID_SUBJECT_URL,
+      publicKey: VALID_PUBLIC_KEY,
+      privateKey: urlBase64.encode(new Buffer(60))
+    },
+    {
+      subject: VALID_SUBJECT_URL,
+      publicKey: VALID_PUBLIC_KEY,
+      privateKey: 'This is invalid'
+    },
+    {
+      subject: VALID_SUBJECT_URL,
+      publicKey: VALID_PUBLIC_KEY,
+      privateKey: ''
+    },
+    {
+      subject: VALID_SUBJECT_URL,
+      publicKey: VALID_PUBLIC_KEY,
+      privateKey: {}
+    },
+    {
+      subject: VALID_SUBJECT_URL,
+      publicKey: VALID_PUBLIC_KEY,
+      privateKey: true
+    }
+  ];
+
+  test('Invalid input should throw an error', function() {
+    invalidInputs.forEach(function(invalidInput, index) {
+      assert.throws(function() {
+        webPush.setVapidDetails(
+          invalidInput.subject,
+          invalidInput.publicKey,
+          invalidInput.privateKey
+        );
+      }, 'Error not thrown on input index: ' + index);
+    });
+  });
+});