Merge pull request #264 from jcloquell/fix-date-picker-allow-editing

Fix the allowEditing prop which was being accidentally ignored

Author: RichardLindhout

example/src/App.tsx

@@ -306,6 +306,8 @@ function App() {
         // animationType="slide" // optional, default is slide on ios/android and none on web
         // startYear={2000} // optional, default is 1800
         // endYear={2100} // optional, default is 2200
+        // allowEditing={false} // optional, default is true
+        // inputEnabled={false} // optional, default is true
       />
 
       <DatePickerModal
@@ -327,6 +329,8 @@ function App() {
         // animationType="slide" // optional, default is 'slide' on ios/android and 'none' on web
         // startYear={2000} // optional, default is 1800
         // endYear={2100} // optional, default is 2200
+        // allowEditing={false} // optional, default is true
+        // inputEnabled={false} // optional, default is true
       />
 
       <DatePickerModal

src/Date/DatePickerModalContent.tsx

@@ -165,7 +165,7 @@ export function DatePickerModalContent(
           locale={locale}
           editIcon={props?.editIcon}
           calendarIcon={props.calendarIcon}
-          allowEditing={props.allowEditing || true}
+          allowEditing={props.allowEditing ?? true}
         />
       </DatePickerModalHeaderBackground>
       <AnimatedCrossView

src/Date/DatePickerModalContentHeader.tsx

@@ -28,7 +28,6 @@ export interface HeaderContentProps extends HeaderPickProps {
   collapsed: boolean
   onToggle: () => any
   locale: string | undefined
-  inputDate?: boolean
 }
 
 function getLabel(
@@ -62,15 +61,14 @@ export default function DatePickerModalContentHeader(
     uppercase,
     editIcon,
     calendarIcon,
-    inputDate,
     allowEditing,
   } = props
   const theme = useTheme()
   const label = getLabel(props.locale, props.mode, props.label)
 
   const color = useHeaderTextColor()
 
-  const isAllowEditing = allowEditing && mode !== 'multiple' && inputDate !== undefined
+  const isEditingEnabled = allowEditing && mode !== 'multiple'
 
   const supportingTextColor = theme.isV3 ? theme.colors.onSurfaceVariant : color
 
@@ -103,7 +101,7 @@ export default function DatePickerModalContentHeader(
         </View>
       </View>
       <View style={styles.fill} />
-      {isAllowEditing ? (
+      {isEditingEnabled ? (
         <IconButton
           icon={
             collapsed

src/__tests__/Date/__snapshots__/AnimatedCrossView.test.tsx.snap

@@ -488,6 +488,7 @@ exports[`renders collapsed AnimatedCrossView 1`] = `
           onScrollEndDrag={[Function]}
           removeClippedSubviews={false}
           renderItem={[Function]}
+          renderScrollComponent={[Function]}
           scrollEventThrottle={50}
           stickyHeaderIndices={[]}
           style={

src/__tests__/Date/__snapshots__/Calendar.test.tsx.snap

@@ -463,6 +463,7 @@ exports[`renders Calendar 1`] = `
       onScrollEndDrag={[Function]}
       removeClippedSubviews={false}
       renderItem={[Function]}
+      renderScrollComponent={[Function]}
       scrollEventThrottle={50}
       stickyHeaderIndices={[]}
       style={

src/__tests__/Date/__snapshots__/YearPicker.test.tsx.snap

@@ -444,6 +444,7 @@ exports[`renders YearPicker 1`] = `
     onScrollEndDrag={[Function]}
     removeClippedSubviews={false}
     renderItem={[Function]}
+    renderScrollComponent={[Function]}
     scrollEventThrottle={50}
     stickyHeaderIndices={[]}
     style={