Merge branch 'development' of github.com:web-ridge/react-native-paper-dates

Author: RichardLindhout

.gitignore

@@ -38,7 +38,7 @@ android.iml
 
 # Cocoapods
 #
-example/ios/Pods
+old-example/ios/Pods
 
 # node.js
 #

CONTRIBUTING.md

@@ -10,7 +10,7 @@ To get started with the project, run `yarn bootstrap` in the root directory to i
 yarn bootstrap
 ```
 
-While developing, you can run the [example app](/example/) to test your changes.
+While developing, you can run the [example app](/old-example/) to test your changes.
 
 To start the packager:
 
@@ -53,19 +53,6 @@ To edit the Objective-C files, open `example/ios/PaperDatesExample.xcworkspace`
 
 To edit the Kotlin files, open `example/android` in Android studio and find the source files at `reactnativepaperdates` under `Android`.
 
-### Commit message convention
-
-We follow the [conventional commits specification](https://www.conventionalcommits.org/en) for our commit messages:
-
-- `fix`: bug fixes, e.g. fix crash due to deprecated method.
-- `feat`: new features, e.g. add new method to the module.
-- `refactor`: code refactor, e.g. migrate from class components to hooks.
-- `docs`: changes into documentation, e.g. add usage example for the module..
-- `test`: adding or updating tests, eg add integration tests using detox.
-- `chore`: tooling changes, e.g. change CI config.
-
-Our pre-commit hooks verify that your commit message matches this format when committing.
-
 ### Linting and tests
 
 [ESLint](https://eslint.org/), [Prettier](https://prettier.io/), [TypeScript](https://www.typescriptlang.org/)

README.md

@@ -1,12 +1,13 @@
 ## react-native-paper-dates
 
-- Smooth and fast cross platform Material Design date picker for React Native Paper
+- Smooth and fast cross platform Material Design **date** picker and **time** picker for React Native Paper
 - Tested on Android, iOS and the web platform!
 - Uses the native Date.Intl API's which work out of the box on the web / iOS
 - Simple API
 - Typesafe
 - Endless scrolling
 - Performant
+- Great react-native-web support
 
 Older demo of this library.   
 <img src="https://user-images.githubusercontent.com/6492229/90681177-4970f280-e263-11ea-8257-6810c5166f92.gif"/>
@@ -66,8 +67,9 @@ function SingleDatePage() {
         onDismiss={onDismiss}
         date={date}
         onConfirm={onChange}
-        saveLabel={'Save'} // optional
-        label={'Select period'} // optional
+        saveLabel="Save" // optional
+        label="Select date" // optional
+        animationType="slide" // optional, default is 'slide' on ios/android and 'none' on web
       />
       <Button onPress={()=> setVisible(true)}>
         Pick date
@@ -98,16 +100,17 @@ export default function RangeDatePage() {
   return (
     <>
       <DatePickerModal
-          mode="range"
-          visible={visible}
-          onDismiss={onDismiss}
-          startDate={undefined}
-          endDate={undefined}
-          onConfirm={onChange}
-          saveLabel={'Save'} // optional
-          label={'Select period'} // optional
-          startLabel={'From'} // optional
-          endLabel={'To'} // optional
+        mode="range"
+        visible={visible}
+        onDismiss={onDismiss}
+        startDate={undefined}
+        endDate={undefined}
+        onConfirm={onChange}
+        saveLabel="Save" // optional
+        label="Select period" // optional
+        startLabel="From" // optional
+        endLabel="To" // optional
+        animationType="slide" // optional, default is slide on ios/android and none on web
       />
       <Button onPress={()=> setVisible(true)}>
         Pick range
@@ -118,11 +121,70 @@ export default function RangeDatePage() {
 ```
 
 
+### Time picker
+```tsx
+import * as React from 'react'
+import { Button } from 'react-native-paper'
+import { TimePickerModal } from 'react-native-paper-dates'
+
+export default function TimePickerPage() {
+  const [visible, setVisible] = React.useState(false)
+  const onDismiss = React.useCallback(() => {
+    setVisible(false)
+  }, [setVisible])
+
+  const onConfirm = React.useCallback(
+    ({ hours, minutes }) => {
+      setVisible(false);
+      console.log({ hours, minutes });
+    },
+    [setVisible]
+  );
+
+
+  return (
+    <>
+      <TimePickerModal
+        visible={visible}
+        onDismiss={onDismiss}
+        onConfirm={onConfirm}
+        hours={12} // default: current hours
+        minutes={14} // default: current minutes
+        label="Select time" // optional, default 'Select time'
+        cancelLabel="Cancel" // optional, default: 'Cancel'
+        confirmLabel="Ok" // optional, default: 'Ok'
+        animationType="fade" // optional, default is 'none'
+      />
+      <Button onPress={()=> setVisible(true)}>
+        Pick time
+      </Button>
+    </>
+  )
+}
+```
+
+
+
+
+
 
 ## Roadmap
-Things on our roadmap are labeled with enhancement.
+Things on our roadmap have labels with `enhancement`.
 https://github.com/web-ridge/react-native-paper-dates/issues
 
+## Tips & Tricks
+- Use 0.14+ version of React-Native-Web (Modal and better number input)
+- Try to avoid putting the pickers inside of a scrollView
+If that is **not possible** use the following props on the surrounding ScrollViews/Flatlists
+
+```javascript
+    keyboardDismissMode="on-drag"
+    keyboardShouldPersistTaps="handled"
+    contentInsetAdjustmentBehavior="always"
+```
+This is to prevent the need to press 2 times before save works (1 press for closing keyboard, 1 press for confirm/close)
+(https://github.com/facebook/react-native/issues/10138)
+
 ## Android Caveats
 
 You will need to add a polyfill for the Intl API on Android if:

example/.buckconfig

@@ -0,0 +1,6 @@
+
+[android]
+  target = Google Inc.:Google APIs:23
+
+[maven_repositories]
+  central = https://repo1.maven.org/maven2

example/.env

@@ -0,0 +1 @@
+SKIP_PREFLIGHT_CHECK=true

example/.eslintrc.js

@@ -0,0 +1,4 @@
+module.exports = {
+  root: true,
+  extends: '@react-native-community',
+};

example/.flowconfig

@@ -0,0 +1,73 @@
+[ignore]
+; We fork some components by platform
+.*/*[.]android.js
+
+; Ignore "BUCK" generated dirs
+<PROJECT_ROOT>/\.buckd/
+
+; Ignore polyfills
+node_modules/react-native/Libraries/polyfills/.*
+
+; These should not be required directly
+; require from fbjs/lib instead: require('fbjs/lib/warning')
+node_modules/warning/.*
+
+; Flow doesn't support platforms
+.*/Libraries/Utilities/LoadingView.js
+
+[untyped]
+.*/node_modules/@react-native-community/cli/.*/.*
+
+[include]
+
+[libs]
+node_modules/react-native/interface.js
+node_modules/react-native/flow/
+
+[options]
+emoji=true
+
+esproposal.optional_chaining=enable
+esproposal.nullish_coalescing=enable
+
+module.file_ext=.js
+module.file_ext=.json
+module.file_ext=.ios.js
+
+munge_underscores=true
+
+module.name_mapper='^react-native/\(.*\)$' -> '<PROJECT_ROOT>/node_modules/react-native/\1'
+module.name_mapper='^@?[./a-zA-Z0-9$_-]+\.\(bmp\|gif\|jpg\|jpeg\|png\|psd\|svg\|webp\|m4v\|mov\|mp4\|mpeg\|mpg\|webm\|aac\|aiff\|caf\|m4a\|mp3\|wav\|html\|pdf\)$' -> '<PROJECT_ROOT>/node_modules/react-native/Libraries/Image/RelativeImageStub'
+
+suppress_type=$FlowIssue
+suppress_type=$FlowFixMe
+suppress_type=$FlowFixMeProps
+suppress_type=$FlowFixMeState
+
+suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(<VERSION>\\)? *\\(site=[a-z,_]*react_native\\(_ios\\)?_\\(oss\\|fb\\)[a-z,_]*\\)?)\\)
+suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(<VERSION>\\)? *\\(site=[a-z,_]*react_native\\(_ios\\)?_\\(oss\\|fb\\)[a-z,_]*\\)?)\\)?:? #[0-9]+
+suppress_comment=\\(.\\|\n\\)*\\$FlowExpectedError
+
+[lints]
+sketchy-null-number=warn
+sketchy-null-mixed=warn
+sketchy-number=warn
+untyped-type-import=warn
+nonstrict-import=warn
+deprecated-type=warn
+unsafe-getters-setters=warn
+unnecessary-invariant=warn
+signature-verification-failure=warn
+deprecated-utility=error
+
+[strict]
+deprecated-type
+nonstrict-import
+sketchy-null
+unclear-type
+unsafe-getters-setters
+untyped-import
+untyped-type-import
+
+[version]
+^0.122.0

example/.gitattributes

@@ -0,0 +1 @@
+*.pbxproj -text

example/.gitignore

@@ -0,0 +1,59 @@
+# OSX
+#
+.DS_Store
+
+# Xcode
+#
+build/
+*.pbxuser
+!default.pbxuser
+*.mode1v3
+!default.mode1v3
+*.mode2v3
+!default.mode2v3
+*.perspectivev3
+!default.perspectivev3
+xcuserdata
+*.xccheckout
+*.moved-aside
+DerivedData
+*.hmap
+*.ipa
+*.xcuserstate
+
+# Android/IntelliJ
+#
+build/
+.idea
+.gradle
+local.properties
+*.iml
+
+# node.js
+#
+node_modules/
+npm-debug.log
+yarn-error.log
+
+# BUCK
+buck-out/
+\.buckd/
+*.keystore
+!debug.keystore
+
+# fastlane
+#
+# It is recommended to not store the screenshots in the git repo. Instead, use fastlane to re-generate the
+# screenshots whenever they are needed.
+# For more information about the recommended setup visit:
+# https://docs.fastlane.tools/best-practices/source-control/
+
+*/fastlane/report.xml
+*/fastlane/Preview.html
+*/fastlane/screenshots
+
+# Bundle artifact
+*.jsbundle
+
+# CocoaPods
+/ios/Pods/

example/.prettierrc.js

@@ -0,0 +1,9 @@
+module.exports = {
+  trailingComma: 'es5',
+  tabWidth: 2,
+  semi: true,
+  singleQuote: true,
+  useTabs: false,
+  printWidth: 80,
+  jsxBracketSameLine: false,
+};