[TASK] Replace custom SiteBaseTestTrait implementation
#459
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make frontend requests within functional tests a proper
frontend page setup is required, and TYPO3 uses internally
a
SiteBasedTestTraitfor own tests, which is not providedin distrubtion packages.
Extension created and maintained there own versions, and in
some cased tried to make it working against multiple TYPO3
versions. Doing the same work again and again when having
multiple extension in the portfolio is a inefficient way.
To mitigate this, a dedicated package has been created now
to provide it in a central way and maintain it in one place.
This change replaces a custom implementation or the usage of
the TYPO3 implementation added with a source install of the
EXT:coresystem extension making the use easier.The new package is added as development dependency and usage
throughout the functional tests are replaced and finaly the
custom implementation removed.
The package also provides a extended
FunctionalTestCase,which is also used to prepare for proper SiteSets based
functional frontend request testing by overriding a method
essential in this case to make it possible not to create
a
sys_templaterecord.As a sideeffect we can now remove some phpstan error patterns,
which are properly defined and mitigated with the 3rd party
package.
Used command(s):