Handle JSON containing incomplete "deals" arrays (#27)

* Add test for Client.Status unmarshalling incomplete deals

Occassionally, the /status and /user/uploads endpoints return JSON
whose "deals" array contains elements missing time.Time fields such as
_activation_, _created_, and _updated_. This results in
Client.Status() and Client.List() returning errors to the effect of
"parsing time "" as "2006-01-02T15:04:05.999Z07:00": cannot parse ""
as "2006"". As per
web3-storage/web3.storage#1512 (comment)
, consumers of these endpoints should accept such data gracefully.

This commit comprises a failing test illustrating the problem.

* status: Ignore empty _created_ and _updated_ fields in "deals" array

Occassionally, the /status and /user/uploads endpoints return JSON
whose "deals" array contains elements missing time.Time fields such as
_activation_, _created_, and _updated_. This results in
Client.Status() and Client.List() returning errors to the effect of
"parsing time "" as "2006-01-02T15:04:05.999Z07:00": cannot parse ""
as "2006"". As per
web3-storage/web3.storage#1512 (comment)
, consumers of these endpoints should accept such data gracefully.

This commit fixes the failing test introduced in 110a25a.

Co-authored-by: Ben <[email protected]>

Author: 3456091

status.go

@@ -168,13 +168,17 @@ func (d *Deal) UnmarshalJSON(b []byte) error {
 			return err
 		}
 	}
-	d.Created, err = time.Parse(iso8601, raw.Created)
-	if err != nil {
-		return err
+	if raw.Created != "" {
+		d.Created, err = time.Parse(iso8601, raw.Created)
+		if err != nil {
+			return err
+		}
 	}
-	d.Updated, err = time.Parse(iso8601, raw.Updated)
-	if err != nil {
-		return err
+	if raw.Updated != "" {
+		d.Updated, err = time.Parse(iso8601, raw.Updated)
+		if err != nil {
+			return err
+		}
 	}
 	return nil
 }

status_test.go

@@ -63,3 +63,69 @@ func TestStatusHappyPath(t *testing.T) {
 		t.Fatalf("got dagsize %d, wanted %d", st.DagSize, 208)
 	}
 }
+
+var statusIncompleteDealHandler = func(w http.ResponseWriter, r *http.Request) {
+	carbytes, err := hex.DecodeString(helloCarHex)
+	if err != nil {
+		fmt.Printf("DecodeString: %v\n", err)
+		w.WriteHeader(http.StatusInternalServerError)
+		return
+	}
+
+	status := map[string]interface{}{
+		"cid":     helloRoot,
+		"dagSize": len(carbytes),
+		"created": "2022-02-20T15:04:05.999Z",
+		"pins":    []interface{}{},
+		"deals": []map[string]interface{}{
+			{
+				"dealId":            0,
+				"storageProvider":   "",
+				"status":            "Queued",
+				"pieceCid":          "baga6ea4seaql2leesalhfwmb5xbvhrotu4x76mxn25wcpile6qpbn777omdmqfa",
+				"dataCid":           "bafybeieesr6dknelbduxqmmtt7q2nernm4mmka4k66t7f4d6sgsq3ixc4u",
+				"dataModelSelector": "Links/144/Hash/Links/2/Hash/Links/0/Hash",
+				"activation":        "",
+				"expiration":        "",
+				"created":           "",
+				"updated":           "",
+			},
+		},
+	}
+
+	w.Header().Set("Content-Type", "application/json")
+
+	w.WriteHeader(http.StatusOK)
+	json.NewEncoder(w).Encode(status)
+}
+
+func TestStatusIncompleteDeal(t *testing.T) {
+	routes := routeMap{
+		"/status/" + helloRoot: {
+			http.MethodGet: statusIncompleteDealHandler,
+		},
+	}
+
+	hc, cleanup := startTestServer(t, routes)
+	defer cleanup()
+
+	client, err := NewClient(WithHTTPClient(hc), WithToken("validtoken"))
+	if err != nil {
+		t.Fatalf("failed to create client: %v", err)
+	}
+
+	c, _ := cid.Parse(helloRoot)
+
+	st, err := client.Status(context.Background(), c)
+	if err != nil {
+		t.Fatalf("failed to send request: %v", err)
+	}
+
+	if st.Cid.String() != helloRoot {
+		t.Fatalf("got cid %s, wanted %s", st.Cid.String(), helloRoot)
+	}
+
+	if st.DagSize != 208 {
+		t.Fatalf("got dagsize %d, wanted %d", st.DagSize, 208)
+	}
+}