Fixing review issues.

Author: yaroslavyaroslav

Sources/Core/Oracle/GasOracle.swift

@@ -137,7 +137,7 @@ final public class Oracle {
             latestBlockNumber = block
         case let .exact(number): latestBlockNumber = number
             // Error throws since pending and erliest are unable to be used in this method.
-        default: throw Web3Error.valueError
+        default: throw Web3Error.valueError()
         }
 
         /// checking if latest block number is greather than number of blocks to take in account

Sources/Core/Transaction/Policies.swift

@@ -54,12 +54,6 @@ public struct Policies {
         }
 
     public static var auto: Policies {
-        Policies(
-            noncePolicy: .latest,
-            gasLimitPolicy: .automatic,
-            gasPricePolicy: .automatic,
-            maxFeePerGasPolicy: .automatic,
-            maxPriorityFeePerGasPolicy: .automatic
-        )
+        Policies()
     }
 }

Sources/Core/Web3Error/Web3Error.swift

@@ -13,7 +13,7 @@ public enum Web3Error: Error {
 
     case dataError
     case typeError
-    case valueError
+    case valueError(desc: String? = nil)
     case serverError(code: Int)
     case clientError(code: Int)
 

Sources/web3swift/Operations/ReadOperation.swift

@@ -19,8 +19,6 @@ public class ReadOperation {
     var policyResolver: PolicyResolver
     var web3: Web3
 
-    public var provider: Web3Provider { web3.provider }
-
     // FIXME: Rewrite this to CodableTransaction
     public init(transaction: CodableTransaction = CodableTransaction.emptyTransaction,
                 web3 web3Instance: Web3,

Sources/web3swift/Utils/Hooks/NonceMiddleware.swift

@@ -16,6 +16,8 @@ extension Web3.Utils {
         public var synchronizationPeriod: TimeInterval = 300.0 // 5 minutes
         var lastSyncTime: Date = Date()
 
+        public init() { }
+
         public func functionToRun() async {
             guard let w3 = self.web3 else { return }
             let knownKeys = Array(nonceLookups.keys)
@@ -35,6 +37,5 @@ extension Web3.Utils {
             }
         }
 
-        public init() { }
     }
 }

Sources/web3swift/Web3/Web3+Resolver.swift

@@ -22,6 +22,8 @@ public class PolicyResolver {
             // Nonce should be resolved first - as this might be needed for some
             // tx's gas estimation
             tx.nonce = try await resolveNonce(for: tx, with: policies.noncePolicy)
+        } else {
+            throw Web3Error.valueError(desc: "Could not be resolved with both from and sender are nil")
         }
 
         tx.gasLimit = try await resolveGasEstimate(for: tx, with: policies.gasLimitPolicy)
@@ -83,7 +85,7 @@ public class PolicyResolver {
     public func resolveNonce(for tx: CodableTransaction, with policy: NoncePolicy) async throws -> BigUInt {
         switch policy {
         case .pending, .latest, .earliest:
-            guard let address = tx.from ?? tx.sender else { throw Web3Error.valueError }
+            guard let address = tx.from ?? tx.sender else { throw Web3Error.valueError() }
             let request: APIRequest = .getTransactionCount(address.address, tx.callOnBlock ?? .latest)
             let response: APIResponse<BigUInt> = try await APIRequest.sendRequest(with: provider, for: request)
             return response.result