Skip to content

Commit 6c9321d

Browse files
Make AbstractEnvelope and all relevant to it types internal,
to give ability to refactor them after release.
1 parent dcbfee3 commit 6c9321d

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

Sources/Core/Transaction/Envelope/AbstractEnvelope.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ public enum EncodeType {
6363
/// All envelopes must conform to this protocol to work with `CodableTransaction`
6464
/// each implememtation holds all the type specific data
6565
/// and implments the type specific encoding/decoding
66-
public protocol AbstractEnvelope: CustomStringConvertible { // possibly add Codable?
66+
protocol AbstractEnvelope: CustomStringConvertible { // possibly add Codable?
6767

6868
/// The type of transaction this envelope represents
6969
var type: TransactionType { get }
@@ -139,7 +139,7 @@ public protocol AbstractEnvelope: CustomStringConvertible { // possibly add Coda
139139
mutating func clearSignatureData()
140140
}
141141

142-
public extension AbstractEnvelope {
142+
extension AbstractEnvelope {
143143

144144
var sender: EthereumAddress? {
145145
guard let publicKey = publicKey else { return nil }

Sources/Core/Transaction/Envelope/EIP2718Envelope.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import BigInt
99
// EIP-2718 is an abstract envelope type
1010
// All typed transactions should inherit from this type and not AbstractEnvelope
1111
// This is just a convenience handle so we can extend with default implementations for EIP-2718 type transactions (currently EIP-2930 and EIP-1559)
12-
public protocol EIP2718Envelope: AbstractEnvelope {
12+
protocol EIP2718Envelope: AbstractEnvelope {
1313
// type: -- Technically 'type' should be here, but it was promoted up to AbstractEnvelope, so we could wrap a LegacyTransaction as well
1414
}
1515

0 commit comments

Comments
 (0)